First step in implementing upsample_bilinear2d_aa #8090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManfeiBai
approved these changes
Sep 28, 2024
barney-s
force-pushed
the
upsample_bilinear2d
branch
5 times, most recently
from
b7b3238 to
a8b34ed
Compare
barney-s
force-pushed
the
upsample_bilinear2d
branch
from
a8b34ed to
1ae9011
Compare
barney-s
changed the title
dvhg
pushed a commit
to dvhg/xla
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented upsample_bilinear2d_aa
Tests the pass sample_h, sample_w are failing. Will fix that in a subsequent PR and enable tests.
Basic tests are passing, including one with align_corners=True.
Test Failing params: