Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUDA plugin CI. #8593

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fix CUDA plugin CI. #8593

wants to merge 11 commits into from

Conversation

ysiraichi
Copy link
Collaborator

Fix: #8577

This PR reverts #8286, and bumps CUDA version to 12.3. The latter is needed for successfully compiling GPU dependent source code that makes use of CUgraphConditionalHandle (not available in 12.1) driver API typedef.

@amjames
Copy link

amjames commented Jan 22, 2025

Looks like the failing jobs are due to a failed clone from kleidiai's gitlab. Is that a widespread issue or spurious failure?

@ysiraichi
Copy link
Collaborator Author

It doesn't look widespread (haven't seen in other PRs). I will try rebasing this PR.

@ysiraichi ysiraichi force-pushed the fix-cuda-plugin-compilation branch from b5474c1 to afc5707 Compare January 22, 2025 15:04
@tengyifei
Copy link
Collaborator

@ysiraichi from pytorch/pytorch#138609 (comment), it looks like PyTorch upstream decided to release with some specific set of CUDA versions (see issue). Can we use one of their chosen versions, for example CUDA 12.4 instead of CUDA 12.3?

@ysiraichi
Copy link
Collaborator Author

Problem is: I didn't find a docker image with CUDA 12.4. Also, I'm not sure how to create one, since it seems something internal.

@tengyifei
Copy link
Collaborator

Problem is: I didn't find a docker image with CUDA 12.4. Also, I'm not sure how to create one, since it seems something internal.

Could you clarify this challenge? Do you mean that you were hoping to find a torch_xla CUDA 12.4 docker build?

@ysiraichi
Copy link
Collaborator Author

As far as I understand, PyTorch/XLA CI relies on docker images (see dev-image). My point is that there is no docker image with CUDA 12.4 in that registry.

# build-torch-with-cuda:
# name: "Build PyTorch with CUDA"
# uses: ./.github/workflows/_build_torch_with_cuda.yml
# needs: get-torch-commit
# with:
# # note that to build a torch wheel with CUDA enabled, we do not need a GPU runner.
# dev-image: us-central1-docker.pkg.dev/tpu-pytorch-releases/docker/development:3.10_cuda_12.1
# torch-commit: ${{needs.get-torch-commit.outputs.torch_commit}}
# runner: linux.24xlarge

@tengyifei
Copy link
Collaborator

As far as I understand, PyTorch/XLA CI relies on docker images (see dev-image). My point is that there is no docker image with CUDA 12.4 in that registry.

@ysiraichi got it. thanks for the explanation. I think using CUDA 12.3 for now is a-okay. IIUC, most of the time we're only using torch CPU + torch_xla GPU in any case.

@tengyifei
Copy link
Collaborator

LMK when I should review. It looks like there are still some failed tests.

@ysiraichi ysiraichi marked this pull request as ready for review January 29, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back PyTorch/XLA GPU tests/builds
3 participants