Skip to content

Migrate runtime.xla_device in favor of core.xla_model.xla_device #9200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 2, 2025
Merged

Migrate runtime.xla_device in favor of core.xla_model.xla_device #9200

merged 9 commits into from
Jun 2, 2025

Conversation

ghpvnist
Copy link
Collaborator

@ghpvnist ghpvnist commented May 19, 2025 •
edited
Loading

fixes #7831

@ghpvnist ghpvnist self-assigned this May 19, 2025
yaoshiang
yaoshiang requested changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@yaoshiang yaoshiang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to further harmonize our docs to the idiomatic torch.device("xla"), torch.device("xla:0"), and torch.device("xla", 1)?

@ghpvnist ghpvnist force-pushed the 7831 branch 2 times, most recently from a76ef1c to 3fa7eb2 Compare May 27, 2025 22:02
@ghpvnist ghpvnist requested a review from yaoshiang May 27, 2025 22:04
@ghpvnist ghpvnist marked this pull request as ready for review May 28, 2025 18:18
tengyifei
tengyifei approved these changes May 28, 2025
View reviewed changes
Copy link
Collaborator

@tengyifei tengyifei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp for docs only

tengyifei
tengyifei reviewed May 28, 2025
View reviewed changes
mikegre-google
mikegre-google approved these changes May 28, 2025
View reviewed changes
@ghpvnist ghpvnist enabled auto-merge (squash) June 2, 2025 21:11
yaoshiang
yaoshiang reviewed Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@yaoshiang yaoshiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm requesting more changes but going to leave this as a "comment" since i know this PR has been hanging around for a long time.

@ghpvnist ghpvnist requested a review from yaoshiang June 2, 2025 21:46
yaoshiang
yaoshiang approved these changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@yaoshiang yaoshiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved given a future PR will address additional requests for standardization of devices in the xla backend for torch

@ghpvnist ghpvnist merged commit 022ecde into pytorch:master Jun 2, 2025
30 of 32 checks passed
@ghpvnist ghpvnist deleted the 7831 branch June 2, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengyifei tengyifei tengyifei approved these changes

@yaoshiang yaoshiang yaoshiang approved these changes

@mikegre-google mikegre-google mikegre-google approved these changes

Assignees

@ghpvnist ghpvnist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusion between xla_model.xla_device() and runtime.xla_device()
4 participants
@ghpvnist @tengyifei @yaoshiang @mikegre-google