-
Notifications
You must be signed in to change notification settings - Fork 534
Migrate runtime.xla_device in favor of core.xla_model.xla_device #9200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to further harmonize our docs to the idiomatic torch.device("xla"), torch.device("xla:0"), and torch.device("xla", 1)?
a76ef1c
to
3fa7eb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubberstamp for docs only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm requesting more changes but going to leave this as a "comment" since i know this PR has been hanging around for a long time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved given a future PR will address additional requests for standardization of devices in the xla backend for torch
fixes #7831