Skip to content

Disable AMP by default on CPU #9218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions benchmarks/torchbench_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,10 @@ def is_accelerator_tpu(self):
return self.benchmark_experiment.accelerator == "tpu"

def use_amp(self):
# AMP is only supported on cuda and tpu, not on cpu.
if self.benchmark_experiment.accelerator == "cpu":
logger.warning("AMP is not used due to running on CPU.")
return False
return self.is_training() or self.model_name in config(
).dtype.force_amp_for_fp16_bf16_models

Expand Down
33 changes: 33 additions & 0 deletions test/benchmarks/test_torchbench_model.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import unittest

from benchmarks.torchbench_model import TorchBenchModel


class MockExperiment:

def __init__(self, accelerator, test):
self.accelerator = accelerator
self.test = "train"


class TorchBenchModelTest(unittest.TestCase):

def test_do_not_use_amp_on_cpu_and_warns(self):
experiment = MockExperiment("cpu", "train")
model = TorchBenchModel("torchbench or other", "super_deep_model",
experiment)
with self.assertLogs('benchmarks.torchbench_model', level='WARNING') as cm:
use_amp = model.use_amp()
self.assertEqual(len(cm.output), 1)
self.assertIn("AMP is not used", cm.output[0])
self.assertFalse(use_amp)

def test_use_amp_on_cuda(self):
experiment = MockExperiment("cuda", "train")
model = TorchBenchModel("torchbench or other", "super_deep_model",
experiment)
self.assertTrue(model.use_amp())


if __name__ == '__main__':
unittest.main()
Loading