New feature: adding scores for the last trip and ratio ev_distance / distance for statistics by julesxxl · Pull Request #160 · pytoyoda/ha_toyota

julesxxl · 2025-09-11T15:32:38Z

Must be merged AFTER the corresponding PR in pytoyoda repo. That will add the scores for the last trip as a sensor (global score as global value and sub-scores as properties). Global score, acceleration score, braking score, advice score and constant speed score.

Plus: ev_distance / distance percentage for each statistics sensor (interesting if your insurance is based on this value, so that you can get a lower price the next year).

(All checks passed here.)

(yaris_none because I hadn't specified the name in the .json)

…statistics

for more information, see https://pre-commit.ci

julesxxl · 2025-09-11T15:46:34Z

OK, The fist workflow failed because I had already put the new version of pytoyoda... which is required before this PR can be merged.

CM000n · 2025-10-02T08:56:10Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new feature to display driving scores from the last trip and an EV distance percentage in statistics. The changes are well-structured and cover documentation, translations, and the core logic. I've identified a few issues, mainly related to sensor configuration, missing capability checks, and minor bugs in calculations that could lead to incorrect data or errors. My review includes suggestions to fix these issues to ensure the new feature is robust and correctly integrated.

gemini-code-assist · 2025-10-02T08:59:01Z

+SCORES_ENTITY_DESCRIPTION = ToyotaScoresEntityDescription(
+    key="score",
+    translation_key="score",
+    icon="mdi:car-info",
+    entity_category=EntityCategory.DIAGNOSTIC,
+    device_class=SensorDeviceClass.ENUM,
+    state_class=None,
+    value_fn=lambda vehicle: vehicle.last_trip.score,
+    attributes_fn=lambda vehicle: format_scores_attributes(
+        vehicle.last_trip,
+        vehicle._vehicle_info,  # noqa : SLF001
+    ),
+)


The SCORES_ENTITY_DESCRIPTION is misconfigured for a sensor that reports a numeric score.

device_class is SensorDeviceClass.ENUM, which is for sensors with a fixed set of string states. For a numeric score (0-100), this is incorrect. It should be None.

state_class should be SensorStateClass.MEASUREMENT to indicate the value is a measurement.

These changes are needed for the sensor to be represented correctly in Home Assistant. Additionally, in create_sensor_configurations at lines 267-268, you should set the units for the score sensor to PERCENTAGE, as it is currently None.

Suggested change

SCORES_ENTITY_DESCRIPTION = ToyotaScoresEntityDescription(

key="score",

translation_key="score",

icon="mdi:car-info",

entity_category=EntityCategory.DIAGNOSTIC,

device_class=SensorDeviceClass.ENUM,

state_class=None,

value_fn=lambda vehicle: vehicle.last_trip.score,

attributes_fn=lambda vehicle: format_scores_attributes(

vehicle.last_trip,

vehicle._vehicle_info, # noqa : SLF001

),

)

SCORES_ENTITY_DESCRIPTION = ToyotaScoresEntityDescription(

key="score",

translation_key="score",

icon="mdi:car-info",

entity_category=EntityCategory.DIAGNOSTIC,

device_class=None,

state_class=SensorStateClass.MEASUREMENT,

value_fn=lambda vehicle: vehicle.last_trip.score,

attributes_fn=lambda vehicle: format_scores_attributes(

vehicle.last_trip,

vehicle._vehicle_info, # noqa : SLF001

),

)

gemini-code-assist · 2025-10-02T08:59:01Z

+            "EV_percentage": int((statistics.ev_distance / statistics.distance) * 100)
+            if statistics.ev_distance and statistics.distance
+            else None,


The calculation for EV_percentage has a subtle bug. If statistics.ev_distance is 0, the condition if statistics.ev_distance and statistics.distance will be false, and the attribute will be None. However, the percentage should be 0. The check should be changed to handle this case correctly and be more explicit to avoid division by zero.

Suggested change

"EV_percentage": int((statistics.ev_distance / statistics.distance) * 100)

if statistics.ev_distance and statistics.distance

else None,

"EV_percentage": int((statistics.ev_distance / statistics.distance) * 100)

if statistics.distance and statistics.ev_distance is not None

else None,

gemini-code-assist · 2025-10-02T08:59:02Z

+        return {
+            "score_acceleration": last_trip.score_acceleration
+            if last_trip.score_acceleration
+            else None,
+            "score_braking": last_trip.score_braking
+            if last_trip.score_braking
+            else None,
+            "score_advice": last_trip.score_advice if last_trip.score_advice else None,
+            "score_constant_speed": last_trip.score_constant_speed
+            if last_trip.score_constant_speed
+            else None,
+        }


The logic for formatting score attributes is buggy. A truthiness check on the score value (e.g., if last_trip.score_acceleration) will incorrectly treat a valid score of 0 as a falsy value, causing it to be replaced with None. This can be simplified and corrected by directly returning the score attributes, as None is an acceptable value if the score is not available.

return { "score_acceleration": last_trip.score_acceleration, "score_braking": last_trip.score_braking, "score_advice": last_trip.score_advice, "score_constant_speed": last_trip.score_constant_speed, }

gemini-code-assist · 2025-10-02T08:59:02Z

@@ -118,9 +122,23 @@ All values will show `None` if no data is available for the period.
 | `Average_fuel_consumed` | The average fuel consumption in the respective period (can be l/100km or mpg).  |
 | `EV_distance`           | The driving distiance in EV mode in the respective period .                     |


There's a small typo in the description. It should be "distance" instead of "distiance".

Suggested change

| `EV_distance` | The driving distiance in EV mode in the respective period . |

| `EV_distance` | The driving distance in EV mode in the respective period . |

gemini-code-assist · 2025-10-02T08:59:02Z



+class ScoresData(TypedDict):
+    """Representing Vehicle data."""


The docstring for ScoresData appears to be a copy-paste from VehicleData. It would be clearer if it specifically mentioned scores.

Suggested change

"""Representing Vehicle data."""

"""Representing Scores data."""

gemini-code-assist · 2025-10-02T08:59:02Z

+        native_unit: PERCENTAGE,
+        suggested_unit: PERCENTAGE,
+    ) -> None:
+        """Initialise the ToyotaStatisticsSensor class."""


This docstring seems to be a copy-paste from ToyotaStatisticsSensor. It should refer to ToyotaScoresSensor.

Suggested change

"""Initialise the ToyotaStatisticsSensor class."""

"""Initialise the ToyotaScoresSensor class."""

CM000n · 2025-10-02T09:04:28Z

Please bump the pytoyoda version accordingly to the manifest.json value.

CM000n · 2025-10-02T09:04:48Z

  "issue_tracker": "https://github.com/pytoyoda/ha_toyota/issues",
-  "requirements": ["pytoyoda>=4.0.1,<5.0", "arrow"],
-  "version": "v2.0.16"
+  "requirements": ["pytoyoda>=4.0.2,<5.0", "arrow"],


please bump the pytoyoda version to 4.1.0 instead of 4.0.2

That's done! 😊

Mhmm, wierd. I stille see 4.0.2 instead of 4.1.0 here ^^

CM000n · 2025-10-06T07:47:49Z

Hey @julesxxl, do you need any assistance in finalizing the PR? 😊

julesxxl · 2025-10-06T13:45:04Z

Hey @julesxxl, do you need any assistance in finalizing the PR? 😊

@CM000n : I think it's ok

julesxxl and others added 2 commits September 11, 2025 17:15

adding scores for the last trip and ratio ev_distance / distance for …

eacb756

…statistics

[pre-commit.ci] auto fixes from pre-commit.com hooks

bbc16bc

for more information, see https://pre-commit.ci

julesxxl mentioned this pull request Sep 11, 2025

Hybrid score #93

Open

julesxxl added 2 commits September 11, 2025 17:43

pytoyoda = '^4.0.1' instead 4.0.2 otherwise poetry complains

36c3d6f

Merge branch 'main' of https://github.com/julesxxl/ha_toyota

c456853

CM000n added the 🚀 feature label Oct 1, 2025

gemini-code-assist Bot reviewed Oct 2, 2025

View reviewed changes

pytoyoda deleted a comment from gemini-code-assist Bot Oct 2, 2025

CM000n requested changes Oct 2, 2025

View reviewed changes

CM000n linked an issue Oct 2, 2025 that may be closed by this pull request

Hybrid score #93

Open

bump pytoyoda to 4.0.2

f8dfd4d

CM000n assigned CM000n and julesxxl and unassigned CM000n Oct 2, 2025

julesxxl and others added 3 commits October 2, 2025 13:09

Merge branch 'main' into main

cd10047

Merge branch 'main' into main

435a2cb

Merge branch 'main' into main

896f02b

julesxxl added 3 commits October 6, 2025 15:20

pytoyoda version 4.1.0, not 4.0.2

c20023b

pytoyoda version 4.1.0, not 4.0.2

4e56982

Merge branch 'main' into main

c49df50

Merge branch 'pytoyoda:main' into main

f620bcc

		@@ -118,9 +122,23 @@ All values will show `None` if no data is available for the period.
		\| `Average_fuel_consumed` \| The average fuel consumption in the respective period (can be l/100km or mpg). \|
		\| `EV_distance` \| The driving distiance in EV mode in the respective period . \|

	\| `EV_distance` \| The driving distiance in EV mode in the respective period . \|
	\| `EV_distance` \| The driving distance in EV mode in the respective period . \|



		class ScoresData(TypedDict):
		"""Representing Vehicle data."""

	"""Representing Vehicle data."""
	"""Representing Scores data."""

	"""Initialise the ToyotaStatisticsSensor class."""
	"""Initialise the ToyotaScoresSensor class."""

Conversation

julesxxl commented Sep 11, 2025

Uh oh!

julesxxl commented Sep 11, 2025

Uh oh!

CM000n commented Oct 2, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

CM000n Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

CM000n Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

julesxxl Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

CM000n Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

CM000n commented Oct 6, 2025

Uh oh!

julesxxl commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants