fix: use proper config dir path (#174)#267
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a mechanism to temporarily switch the current working directory to a writable location during the login process to facilitate hishel caching. The review feedback highlights a performance concern regarding blocking I/O operations within the asynchronous config flow and identifies a potential bug in the directory restoration logic within the initialization module, providing a specific code suggestion to ensure the working directory is always safely restored.
scurkovic
force-pushed
the
main
branch
2 times, most recently
from
8205c38 to
a4607e2
Compare
|
@deejay1 I've rebased onto main. |
scurkovic
force-pushed
the
main
branch
3 times, most recently
from
50d1102 to
317e53f
Compare
|
@deejay1 Since you've approved already, and I've been using it in production for a while now, would you mind merging? |
scurkovic
force-pushed
the
main
branch
3 times, most recently
from
bcf6cd4 to
064a16e
Compare
2 participants
This fixes #174 by properly fetching the config directory location from HA and using it as CWD before calling pytoyoda.