Skip to content

Make get_observer_look work on oblate earth#87

Draft
mraspaud wants to merge 2 commits into
mainfrom
fix-observer-look2
Draft

Make get_observer_look work on oblate earth#87
mraspaud wants to merge 2 commits into
mainfrom
fix-observer-look2

Conversation

@mraspaud

Copy link
Copy Markdown
Member

The pyorbital code to compute the observer look was making the assumption that the earth was spherical. While the differences are quite small, we implement here the oblateness of the earth into the function.

@mraspaud mraspaud self-assigned this Nov 12, 2021
@codecov

codecov Bot commented Nov 12, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.55%. Comparing base (e215868) to head (6785eed).
⚠️ Report is 456 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   85.67%   85.55%   -0.12%     
==========================================
  Files          13       13              
  Lines        1947     1932      -15     
==========================================
- Hits         1668     1653      -15     
  Misses        279      279              
Flag Coverage Δ
unittests 85.55% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants