Skip to content

Switch to hatchling#164

Merged
mraspaud merged 18 commits intopytroll:mainfrom
mraspaud:hatch
Sep 11, 2025
Merged

Switch to hatchling#164
mraspaud merged 18 commits intopytroll:mainfrom
mraspaud:hatch

Conversation

@mraspaud
Copy link
Copy Markdown
Member

as a build system, drop versioneer, and update python versions

@mraspaud mraspaud self-assigned this Sep 10, 2025
@djhoese
Copy link
Copy Markdown
Member

djhoese commented Sep 10, 2025

You need hatch-vcs too right?

@mraspaud
Copy link
Copy Markdown
Member Author

You need hatch-vcs too right?

Yes, very likely. I just pushed what "hatch new --init" gave me, it still need to be refined.

Comment thread pyproject.toml Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.85%. Comparing base (b74ab9f) to head (a9cbe70).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   91.92%   90.85%   -1.08%     
==========================================
  Files          28       32       +4     
  Lines        4048     4547     +499     
==========================================
+ Hits         3721     4131     +410     
- Misses        327      416      +89     
Flag Coverage Δ
unittests 90.85% <100.00%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mraspaud mraspaud requested a review from pnuu September 10, 2025 19:50
Copy link
Copy Markdown
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small things. Plus:

You should change codecov file: to files: in ci.yaml. The file parameter is deprecated.

Comment thread .github/workflows/deploy_sdist.yaml Outdated
Comment thread pytroll_collectors/__init__.py
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml
Comment thread .github/workflows/deploy_sdist.yaml
Copy link
Copy Markdown
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments added. In general, LGTM, and thanks for the automatic PyPI job!

Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
geographic_gatherer = [
"pyresample",
"pytroll-schedule",
"watchdog",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have the version limitation also here, or is the one in all sufficient?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding it

@mraspaud mraspaud merged commit 513d70d into pytroll:main Sep 11, 2025
8 of 9 checks passed
@mraspaud mraspaud deleted the hatch branch September 11, 2025 07:57
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 17637879311

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.905%

Totals Coverage Status
Change from base Build 16900002097: 0.0%
Covered Lines: 4158
Relevant Lines: 4574

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants