When critical files are missing, log which ones those are.#176
When critical files are missing, log which ones those are.#176gerritholl wants to merge 1 commit intopytroll:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 80.73% 80.78% +0.04%
==========================================
Files 41 41
Lines 5140 5152 +12
==========================================
+ Hits 4150 4162 +12
Misses 990 990
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I added this to debug why I keep getting "required files were not present", but the logging I added doesn't seem to help, as the missing critical files are the empty set :/ |
|
Does @pnuu have an idea why my PR might log the empty set for missing critical files? |
|
How does your config look like? I guess the critical = set()
received = {1, 2, 5}
print(critical - received)-> |
|
I made some changes in the past couple of days, but I think it was: And from the log: I later changed settings and had no more critical files timeout, but I did not change the code. I should do more live tests to trigger this on purpose. |
|
Converting to draft because it doesn't seem to do what I mean. |
Improve the log message reported when critical files are missing, to inform exactly what critical files are missing.