Image compare in Krokiet, RMB context menu, changed AV1 codec

.github/workflows/windows.yml

@@ -142,11 +142,17 @@ jobs:
           token: ${{ secrets.PAT_REPOSITORY }}
 
   container_4_12:
+    needs: krokiet-compiled-on-windows
     runs-on: ubuntu-latest
     container:
       image: ghcr.io/mglolenstine/gtk4-cross:gtk-4.12
     steps:
       - uses: actions/checkout@v6
+
+      - name: Download Krokiet (skia opengl) artifact
+        uses: actions/download-artifact@v7
+        with:
+          name: krokiet-windows-on-windows-${{ github.sha }}
       - name: Install additional dependencies
         # gio is for the build script
         run: |
@@ -211,6 +217,21 @@ jobs:
           mv libEGL.dll package/
           mv libGLESv2.dll package/
 
+          cp windows_krokiet_on_windows_skia_opengl.exe package/krokiet.exe
+
+          {
+            echo '# Czkawka'
+            echo ''
+            echo 'This package includes the legacy GTK 4 GUI (czkawka_gui.exe), which is now deprecated.'
+            echo ''
+            echo 'The recommended successor is Krokiet.'
+            echo ''
+            echo '**krokiet.exe** (also included in this package) is a new application created by the author of Czkawka.'
+            echo 'It offers better performance, more features, improved Windows/macOS support compared to the legacy GTK GUI.'
+            echo ''
+            echo 'More information: https://github.com/qarmin/czkawka'
+          } > package/README.md
+
       - name: Upload artifacts
         uses: actions/upload-artifact@v6
         with:

.gitignore

@@ -40,4 +40,7 @@ cedinia/android/app/src/main/jniLibs/
 cedinia/android/.gradle/
 cedinia/docs
 *.aab
-*.gz
+*.gz
+/pyproject.toml
+uv.lock
+i18n

CLAUDE.md

@@ -0,0 +1,244 @@
+# Czkawka – Codebase Guide
+
+## Language
+
+All code, comments, commit messages, and documentation must be written in **English**.
+
+---
+
+## Comments
+
+Keep comments minimal. Code should be self-documenting through clear naming. Add a comment only
+when the _why_ is not obvious from reading the code – algorithmic choices, non-obvious constraints,
+workarounds for external library bugs, etc. Do not restate what the code already says.
+
+---
+
+## Panics and `expect()`
+
+`expect()` (and `unwrap()` but only in tests) are acceptable and **preferred** over silently ignoring a failure when
+a failed call would leave the program in an inconsistent or corrupted state. This is visible
+throughout Krokiet's callback code: the Slint weak reference is upgraded with `expect()` because
+if the window is already gone there is nothing meaningful to do except crash.
+
+Rules of thumb:
+- Use `expect()` for logic invariants – things that _cannot_ fail unless there is a programming
+  error (e.g. "failed to upgrade MainWindow weak ref in callback that was just registered").
+- Use proper `Result`/`Option` propagation for _expected_ failures (I/O errors, missing files,
+  user-cancellable operations).
+- Never silently swallow errors with `let _ = ...` unless the failure is genuinely irrelevant.
+- Prefer `unwrap_or_default()` / `unwrap_or_else()` over `unwrap()` when a sensible fallback
+  exists.
+
+---
+
+## Project Goals
+
+Two properties are non-negotiable across every sub-project:
+
+1. **Performance first** – scanning and file operations must be fast. Parallelism via `rayon`,
+   efficient algorithms (e.g. perceptual hashing, blake3), and careful memory use are the norm.
+   Avoid unnecessary allocations or copies in hot paths.
+
+2. **Minimal non-Rust dependencies** – every additional C/C++ library (or any other non-Rust
+   language) makes cross-compilation harder, narrows the set of supported targets, and increases
+   build complexity for contributors. Prefer pure-Rust crates. If a native library is truly
+   necessary (e.g. `libheif`, `libraw`), gate it behind an optional Cargo feature so the default
+   build stays fully Rust.
+
+---
+
+## `just fix` – baseline quality gate
+
+Running `just fix` must pass before any merge request. It runs, in order:
+
+1. `ruff format` – Python code formatting.
+2. `mypy misc --strict` – static type checking for all scripts in `misc/`.
+3. `bash misc/run_checks.sh` – project-specific checks:
+   - `delete_unused_krokiet_slint_imports.py` for krokiet and cedinia
+   - `find_unused_fluent_translations.py` for all four projects
+   - `find_unused_slint_translations.py` for krokiet and cedinia
+   - `find_unused_callbacks.py` for krokiet and cedinia
+   - `find_unused_settings_properties.py` for krokiet and cedinia
+4. `cargo +nightly fmt` + `cargo fmt` – Rust formatting.
+5. `cargo clippy --fix` – Rust linting (two passes: with and without default features).
+
+If `just fix` produces any output on stderr or exits non-zero the code is not ready for review.
+
+---
+
+## Workspace Structure
+
+```
+czkawka/
+├── czkawka_core/   # Scanning logic – shared library used by all frontends
+├── czkawka_cli/    # Command-line interface
+├── czkawka_gui/    # Legacy GTK 4 GUI (maintenance mode only)
+├── krokiet/        # Primary desktop GUI – Slint-based
+├── cedinia/        # Android / mobile GUI – Slint-based
+└── misc/           # Scripts: AI translation, validation, benchmarks, CI helpers
+```
+
+Cargo workspace resolver v3, minimum Rust 1.92.0, edition 2024 throughout.
+
+---
+
+## czkawka_core
+
+The shared scanning engine. Every frontend depends on it; it has no UI dependency.
+
+**Key modules:**
+- `common/` – `CommonToolData` (settings, stop-flag, progress sender), `DirTraversal`, cache,
+  extension filtering, path helpers, progress types.
+- `tools/` – One sub-module per scanning tool:
+  `duplicate`, `empty_folder`, `empty_files`, `big_file`, `similar_images`, `similar_videos`,
+  `same_music`, `broken_files`, `bad_extensions`, `bad_names`, `invalid_symlinks`, `temporary`,
+  `exif_remover`, `video_optimizer`.
+- `localizer_core.rs` – Fluent translation loader for Rust-side messages.
+
+Each tool implements the `CommonData` trait (shared settings access) and `PrintResults` (CSV/JSON
+export). The tool struct is constructed, configured, then its `find_*()` method is called in a
+worker thread. Progress is reported over a `crossbeam` channel; a stop `AtomicBool` is polled to
+support cancellation.
+
+---
+
+## krokiet
+
+The primary desktop GUI. Built with [Slint](https://slint.dev/) (GPL-3.0). The UI is declared
+in `ui/*.slint`; Rust connects callbacks and drives the Slint model.
+
+**Build:** `slint_build` compiles `.slint` sources at build time; `slint::include_modules!()`
+exposes the generated types.
+
+**Entry point:** `src/main.rs`
+- Loads settings, creates `MainWindow`, wires up all callbacks, starts the event loop.
+
+**Callback pattern:**
+```rust
+let weak = app.as_weak();
+app.global::<Callabler>().on_some_action(move || {
+    let app = weak.upgrade().expect("MainWindow dropped while callback is still live");
+    // ...
+});
+```
+Each feature area lives in a dedicated `connect_*.rs` file (e.g. `connect_scan.rs`,
+`connect_compare.rs`, `connect_delete_button.rs`).
+
+**`SharedModels`** (`src/shared_models.rs`):
+An `Arc<Mutex<SharedModels>>` holds the last scan result and parameters of scan of each tool. It is passed to every
+`connect_*` function that needs to access or mutate scan state from a background thread.
+
+**Model layer:**
+- The Slint UI is driven by `ModelRc<VecModel<SingleMainListModel>>`.
+- `SingleMainListModel` carries `val_str: [string]` and `val_int: [int]` vectors – a flat,
+  index-based row representation.
+- Column indices for each tool are defined as constants in `src/common.rs`
+  (`StrDataSimilarImages`, `StrDataDuplicates`, …).
+
+**Translation:** `flk!("key")` / `flk!("key", var = value)` macros defined in
+`src/localizer_krokiet.rs`. Language files in `i18n/<lang-code>/krokiet.ftl`.
+
+---
+
+## cedinia
+
+The Android (and secondary desktop) GUI. Architecture mirrors Krokiet but adapts to mobile
+constraints. Compiled as `cdylib` for Android (loaded via `android-activity`).
+
+**Entry points:**
+- Android: `#[no_mangle] pub fn android_main(app: AndroidApp)` in `src/lib.rs`
+- Desktop: `fn run_app()` in `src/app.rs`
+
+**Android-specific:**
+- File picker uses JNI to call into a Kotlin/Java helper embedded via `include_bytes!` (DEX).
+- Storage permissions requested at runtime; `AppState.storage_permission_granted` gates scanning.
+- System insets (`inset_top`, `inset_bottom`) plumbed through to Slint for edge-to-edge layout.
+- `android_logger` routes Rust log output to logcat.
+
+**Differences from Krokiet:**
+- No video tools (ffmpeg not available on Android).
+- Touch-optimised UI (`cedinia/ui/`); momentum-scroll views, bottom sheets, FAB.
+- `flc!` macro (cedinia-specific) in `src/localizer_cedinia.rs`.
+
+**Translation:** `flc!("key")` macro; language files in `cedinia/i18n/<lang-code>/cedinia.ftl`.
+
+---
+
+## czkawka_cli
+
+Thin wrapper around `czkawka_core`. Uses `clap` (derive API) for argument parsing and `indicatif`
+for progress bars. No GUI code. Results printed via the tool's `PrintResults` trait.
+
+---
+
+## czkawka_gui
+
+Legacy GTK 4 GUI. **Maintenance mode only** – no new features are added. Bug-fixes that
+keep it compatible with core API changes are accepted.
+
+---
+
+## misc/
+
+- `ai_translate/translate.py` – AI-powered batch translation into all supported languages.
+- `ai_translate/validate_translations.py` – Checks placeholder consistency across translations.
+  Pass `--fix` to automatically remove invalid entries.
+- `find_unused_fluent_translations.py` / `find_unused_slint_translations.py` – Dead-code
+  detection for translation keys.
+- `gen_cedinia_licenses.py` – Generates `THIRD_PARTY_LICENSES.txt` from Cargo metadata.
+
+---
+
+## i18n
+
+All user-visible strings use [Fluent](https://projectfluent.org/) (`.ftl` files).
+
+| Project      | Macro  | File pattern                                |
+|--------------|--------|---------------------------------------------|
+| krokiet      | `flk!` | `krokiet/i18n/<lang>/krokiet.ftl`           |
+| cedinia      | `flc!` | `cedinia/i18n/<lang>/cedinia.ftl`           |
+| czkawka_core | `flc!` | `czkawka_core/i18n/<lang>/czkawka_core.ftl` |
+| czkawka_gui  | `flg!` | `czkawka_gui/i18n/<lang>/czkawka_gui.ftl`   |
+
+English is the source/fallback language. All other locales are AI-translated and then validated.
+
+---
+
+## Slint UI conventions
+
+- **Hidden Text elements for width measurement** – where a layout element must adapt its width to
+  translated label text, add off-screen `Text` instances (`x: -10000px; y: -10000px; height: 0`)
+  and compute `preferred-width` at runtime (see `LeftSidePanel`, `CompareInfoBar`).
+- **Enums over strings** – UI state that takes a fixed set of values should use a Slint `enum`,
+  not a `string` (e.g. `ConfirmPopupAction`, `ActiveTool`, `ScanState`).
+- **Global state** – Application-wide state lives in Slint `global` blocks (`GuiState`,
+  `AppState`, `Settings`, `Translations`, …). Rust reads/writes via `app.global::<GlobalName>()`.
+
+---
+
+## Build profiles (Cargo.toml)
+
+| Profile        | Purpose                                                              |
+|----------------|----------------------------------------------------------------------|
+| `release`      | Standard release                                                     |
+| `fast_release` | Incremental, stripped – fast iteration                               |
+| `rdebug`       | Release + full debug symbols (profiling)                             |
+| `fastest`      | Max opt, LTO, panic=abort – mostly benchmarks/poc how fast it can be |
+| `fastci`       | Small binary, fast CI builds                                         |
+
+---
+
+## justfile quick reference
+
+```
+just run krokiet          # debug run
+just runr krokiet         # fast_release run
+just fix                  # format + clippy + Python checks
+just translate            # AI-translate all projects
+just validate_translations [--fix]
+just pack_translations    # create i18n_translations.zip for Crowdin
+just unpack_translations <path>
+just android              # build + install + launch on device
+just androidr             # release variant
+```