Fix prehash cache bypass causing full hash on all files in second scan#1907
Open
darktorres wants to merge 1 commit intoqarmin:masterfrom
Open
Fix prehash cache bypass causing full hash on all files in second scan#1907darktorres wants to merge 1 commit intoqarmin:masterfrom
darktorres wants to merge 1 commit intoqarmin:masterfrom
Conversation
…d scan Cached prehash entries were appended to pre_checked_map unconditionally, skipping the collision filter that freshly-computed entries go through. On a second scan where all files are cached, every file was forwarded to full hashing regardless of prehash result. Also fixed a latent bug where a cached file and a freshly-computed file sharing the same prehash were never detected as a collision, since each loop only checked within its own set. Both loops are now replaced with a single merge-then-filter pass over a combined (size -> hash -> files) map. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre_checked_mapunconditionally, skipping thelen() > 1collision filter that freshly-computed entries go through. On a second scan where all files are cached, every file was forwarded to full hashing regardless of whether their prehashes actually collided.(size -> hash -> files)map.Test plan
cargo check -p czkawka_core— clean compilecargo test -p czkawka_core -- duplicate) — all pass🤖 Generated with Claude Code