fix: issue with attaching screenshots for failed tests in subdirectories #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bdirectories - Added recursive folder search by a specified name. - Screenshots for failed tests are now correctly attached, even if the tests are located in subdirectories.
gibiw
force-pushed
the
fix/cypress_screenshots
branch
from
eb22c5a to
f9cb1a7
Compare
apetrosyan1613
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
qase-cypresspackage, focusing on fixing an issue with screenshot attachments for failed tests and updating the package version. The most important changes are the addition of a new method to search for folders by name and modifying the file search logic to correctly handle subdirectories.Fixes and improvements:
qase-cypress/changelog.md: Added a new entry for version2.2.6detailing the fix for attaching screenshots of failed tests located in subdirectories.qase-cypress/package.json: Updated the package version from2.2.5to2.2.6.Code changes:
qase-cypress/src/fileSearcher.ts: Modified thefindFilesBeforeTimemethod to includescreenshotFolderPathandspecFileNameparameters, and added logic to handle subdirectories. Introduced a newfindFolderByNamemethod to locate folders by name within a directory. [1] [2]qase-cypress/src/reporter.ts: Updated the call tofindFilesBeforeTimeto use the new parameters for correctly searching screenshot folders.