force-remove all files on Close

[tgulacsi]

PR Details

Force removing of all temporary files on File.Close().

Description

Don't quit on error while removing temp files during iteration over tempFiles Map.

Related Issue

#2119

Motivation and Context

Some of the temp files may be left there, occupying space.

How Has This Been Tested

go test

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[xuri]

Hi @tgulacsi, please resolve the merge conflicts.

[tgulacsi]

Hmm, I've started from v2, should it've been master ?

[xuri]

Yeah, please made changes based on master branch.

[tgulacsi]

(Just a warning: the new TestZip64 needs at least 4GiB of temp space. I've had to increase my /tmp (its a tmpfs) - not a problem, just otherwise that test fails. Shall we Skip it if not enough space is there?)

[xuri]

I don't recommend skipping this test, only skipping it in GitHub Action pipeline.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (3ccbdaa) to head (a8c0fed).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2120   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          32       32           
  Lines       30192    30196    +4     
=======================================
+ Hits        29961    29965    +4     
  Misses        153      153           
  Partials       78       78           

Flag	Coverage Δ
unittests	99.23% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[xuri]

LGTM, thanks for your contribution.