This close #2146, support setting excel custom properties#2147
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2147 +/- ##
========================================
Coverage 99.23% 99.23%
========================================
Files 32 32
Lines 30276 30378 +102
========================================
+ Hits 30045 30147 +102
Misses 153 153
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
edfc003 to
ab0b6f1
Compare
xuri
left a comment
There was a problem hiding this comment.
Thanks for your PR. I've left some comments.
2990830 to
e58fdbc
Compare
|
@xuri hi xuri, i have solved the comments, please take a look again. |
…erties in DocProps/custom.xml) - support save some biz k:v data to excel custom properties to do such that save excel biz version etc. Change-Id: I4a524b494f09fbfca321d515b5029f4f7361311f Signed-off-by: mengzhongyuan <mengzhongyuan@bytedance.com>
|
@xuri something else should i do before merging this to base? |
|
No action required, this PR has a lot of code, I need some time to review. |
xuri
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I've made some modification based on your branch.
Change-Id: I4a524b494f09fbfca321d515b5029f4f7361311f
PR Details
support setting excel custom properties (actual file in DocProps/custom.xml) to save some biz info like biz version for further uses.
Description
Related Issue
#2146
Motivation and Context
I have a requirement that save some biz k:v data in the generated excel file, before i implent it my program wrote a hidden excel to save some such data.
How Has This Been Tested
Types of changes
Checklist