Breaking changes: Go 1.25.0 and later required for upgrade of dependency package golang.org/x/net#2270
Merged
Merged
Conversation
…ncy package `golang.org/x/net` - Fix NEGBINOM.DIST formula function result not consistent between multiple platform - Update GitHub Action config, test on macOS 26 with Apple Silicon arch - Update dependencies modules
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2270 +/- ##
==========================================
- Coverage 99.56% 99.56% -0.01%
==========================================
Files 32 32
Lines 26303 26299 -4
==========================================
- Hits 26188 26184 -4
Misses 60 60
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…consistency between ARM64 (Apple Silicon) and Intel
xuri
approved these changes
Mar 7, 2026
Member
xuri
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
golang.org/x/netDescription
On ARM64 (Apple Silicon), Go's compiler automatically fuses multiply-add operations into hardware FMA (fused multiply-add) instructions, which round only once instead of twice. On Intel/AMD64, these remain as separate multiply + add operations with two roundings. This causes ~1 ULP (Unit of Least Precision) differences that accumulate over the iterative continued fraction loop.
Related Issue
N/A
Motivation and Context
golang.org/x/netHow Has This Been Tested
Test locally
Types of changes
Checklist