feat: add SheetStats with GetSheetStats and CalculateSheetStats (E1)#2327
Open
AdamDrewsTR wants to merge 2 commits into
Open
feat: add SheetStats with GetSheetStats and CalculateSheetStats (E1)#2327AdamDrewsTR wants to merge 2 commits into
AdamDrewsTR wants to merge 2 commits into
Conversation
Add SheetStats struct containing computed worksheet statistics: - Rows: total number of rows with data - Cols: maximum column index used - Cells: total number of non-empty cells - MaxCell: cell reference of the bottom-right used cell CalculateSheetStats iterates all rows/columns in a sheet using the Rows iterator, computes the statistics, and caches the result in the File struct. Subsequent calls return the cached value. GetSheetStats returns previously cached stats without recalculating.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2327 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 32 32
Lines 26791 26824 +33
=======================================
+ Hits 26685 26718 +33
Misses 55 55
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add comprehensive tests for GetSheetStats and CalculateSheetStats covering normal operation, caching, empty sheets, non-existent sheets, and Columns() error paths. Remove unreachable rows.Error() check since Rows.err is never set in the standard implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
SheetStatsstruct and methods to compute and cache worksheet data extent statistics.SheetStats Struct
Methods
CalculateSheetStats(sheet string) (*SheetStats, error)— Iterates all rows/columns using theRowsiterator, computes statistics, and caches the result. Subsequent calls return the cached value.GetSheetStats(sheet string) *SheetStats— Returns previously cached stats without recalculating, ornilif not yet computed.Usage