feat: use embed for template#2332
Closed
kenny-not-dead wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2332 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 32 32
Lines 26855 26855
=======================================
Hits 26749 26749
Misses 55 55
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xuri
reviewed
Jun 1, 2026
Member
xuri
left a comment
There was a problem hiding this comment.
Thanks for the PR. Since the new template files use pretty-printing with four space indentation and newlines, it increases the default workbook size and effect file-hash comparisons for users, so I don't think this change is necessary. You can easily introduce new variables in template.go within your own fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
use package embed for template
Description
convenient way to interact with templates
Related Issue
Motivation and Context
Inspired by your library, I'm developing my own, based on your approach, but for processing pptx presentations. When working with templates, I found viewing the base template as a string rather inconvenient. Embed solved this problem.
so I wanted to offer this to you after some time
How Has This Been Tested
go test
Types of changes
Checklist