Resolved all warning from Lua Diagnostic and added some missing typings - #1200
Resolved all warning from Lua Diagnostic and added some missing typings#1200MuDzYNN wants to merge 1 commit into
Conversation
|
Personally a waste of a PR, most of what you changed is the same output but the first change at the top, why define coords when only calling it 3 times when you can keep it how it is in the first place? |
|
Yeah I know, that's why I'm wrote that this don't change any functionality. It's simply better to work in a project that doesn't have unnecessary warnings. About defining coords - I also do that to resolve warning about missing parameters, because |
I dont really understand this take, especially why its so harsh. Ofcourse this provides value? And its obvious someone put down time and effort to make this.... Opening up a project/resource and seeing a bunch of warnings, most of which arent even "real", isnt ideal. As it defers us from real warnings. Furthermore, I do actually believe some of these changes are required, as FiveM started forcing lua 5.4 which is much more strict with the return & input values. (Such as using |
Z3rio
left a comment
There was a problem hiding this comment.
Looks good when reading through it, have not tested this ingame or in my editor, though.
|
This PR has had 60 days of inactivity & will close within 7 days |
Description
Basically it won't change any functionality. I just fixed all of warnings that comes from Lua Diagnostic extension. Additionally I added some missing typing for function from
QBCore.Functionsobject.Checklist