Skip to content

Update index.html, editor.js, editor.css, ua.lua - #1204

Closed
DispersiaRoleplay wants to merge 1 commit into
qbcore-fivem:v2.0from
DispersiaRoleplay:v2.0
Closed

Update index.html, editor.js, editor.css, ua.lua#1204
DispersiaRoleplay wants to merge 1 commit into
qbcore-fivem:v2.0from
DispersiaRoleplay:v2.0

Conversation

@DispersiaRoleplay

Copy link
Copy Markdown
Contributor

Description

This PR updates 4 files in qb-core v2.0:

  • html/index.html

    • Hide #editor-container by default (class="hidden"); open only on populateData.
  • html/js/editor.js

    • Show editor on populateData.
    • Close via header Close button or ESC and send NUI closeEditor to release focus.
    • Wire Save Changes to NUI saveConfig for the current file.
    • Safer NUI response parsing (text → JSON with fallback).
  • html/css/editor.css

    • .hidden { display: none !important; }
    • Better readability (white text), lighter card background (matches sidebar),
    • Wrap/line-clamp long JSON, no horizontal overflow.
  • locales/ua.lua

    • Updated/added UA strings for the editor.

Why

  • Editor UI showed on load (not hidden by default).
  • Close/ESC did not release NUI focus.
  • “Save Changes” was not wired to NUI.
  • Dark-on-dark text and overflow in cards affected readability.

Checklist

  • Tested locally on qb-core v2.0.
  • Code/style fits project guidelines.
  • Targets the correct branch (v2.0).

@github-actions

Copy link
Copy Markdown

This PR has had 60 days of inactivity & will close within 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant