Skip to content

Conversation

@famosab
Copy link
Collaborator

@famosab famosab commented Sep 11, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@famosab famosab merged commit 213dd43 into dev Sep 11, 2025
3 of 4 checks passed
@github-actions
Copy link

github-actions bot commented Sep 11, 2025

nf-core pipelines lint overall result: Failed ❌

Posted for pipeline commit 5dc4cb1

+| ✅ 178 tests passed       |+
#| ❔  24 tests were ignored |#
!| ❗   7 tests had warnings |!
-| ❌   1 tests failed       |-
Details

❌ Test failures:

  • rocrate_readme_sync - The RO-Crate descriptions do not match the README.md content. Use nf-core pipelines lint --fix rocrate_readme_sync to update.

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • pipeline_todos - TODO string in README.md: If applicable, make list of people who have also contributed
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-variantconsensus_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-variantconsensus_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-variantconsensus_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • nextflow_config - Config variable ignored: validation.help.beforeText
  • nextflow_config - Config variable ignored: validation.help.afterText
  • nextflow_config - Config variable ignored: validation.summary.beforeText
  • nextflow_config - Config variable ignored: validation.summary.afterText
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/nf-core-variantconsensus_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-variantconsensus_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-variantconsensus_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/variantconsensus/variantconsensus/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.2
  • Run at 2025-09-11 13:09:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants