Skip to content

Don't overwrite config file when it has no write permission#23817

Merged
Chocobo1 merged 1 commit intoqbittorrent:masterfrom
Chocobo1:conf_readonly
Feb 8, 2026
Merged

Don't overwrite config file when it has no write permission#23817
Chocobo1 merged 1 commit intoqbittorrent:masterfrom
Chocobo1:conf_readonly

Conversation

@Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Feb 6, 2026

Related: #23808.
Supersedes: #23809.

@Chocobo1 Chocobo1 added this to the 5.2 milestone Feb 6, 2026
@Chocobo1 Chocobo1 added the Core label Feb 6, 2026
@Chocobo1 Chocobo1 marked this pull request as ready for review February 6, 2026 14:18
@Chocobo1 Chocobo1 requested a review from a team February 6, 2026 14:18
glassez
glassez previously approved these changes Feb 6, 2026
Copy link
Member

@glassez glassez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test.

@Chocobo1
Copy link
Member Author

Chocobo1 commented Feb 6, 2026

PR updated to resolve an edge case where qbt is starting up for the first time (config file not yet created).
PR should be final now.

@Chocobo1 Chocobo1 modified the milestones: 5.2, 5.3 Feb 6, 2026
@Chocobo1 Chocobo1 merged commit c849757 into qbittorrent:master Feb 8, 2026
15 checks passed
@Chocobo1 Chocobo1 deleted the conf_readonly branch February 8, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants