Skip to content

Fix torrents stuck in active state at 1 B/s #23827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stalkerok wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Fix torrents stuck in active state at 1 B/s #23827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/base/bittorrent/torrentimpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,7 +1188,7 @@ bool TorrentImpl::isCompleted() const

bool TorrentImpl::isActive() const
{
return ((uploadPayloadRate() > 0) || (downloadPayloadRate() > 0));
return ((uploadPayloadRate() > 1) || (downloadPayloadRate() > 1));
Copy link
Member

@Chocobo1 Chocobo1 Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 1 won't work, or why it need to be > 1 for active state?
It sounds like a dirty workaround...

Copy link
Member

@glassez glassez Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like a dirty workaround...

👍

Copy link
Contributor Author

@stalkerok stalkerok Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 1 won't work, or why it need to be > 1 for active state? It sounds like a dirty workaround...

This removes torrents from the Active filter, but they will continue to hang at 1 B/s.
The simplest solution was to simply remove them from the filter results in this way.

}

bool TorrentImpl::isInactive() const
Expand Down
2 changes: 1 addition & 1 deletion src/webui/www/private/scripts/dynamicTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1601,7 +1601,7 @@ window.qBittorrent.DynamicTable ??= (() => {
inactive = true;
// fallthrough
case "active": {
const r = (upspeed > 0) || (dlspeed > 0);
const r = (upspeed > 1) || (dlspeed > 1);
if (r === inactive)
return false;
break;
Expand Down
Loading