Allow to filter torrent list by infohash

[stalkerok]

Closes #10893.

[xavier2k6]

Alternative naming:

Allow to filter torrent list by infohash

Allow to filter transferlist by infohash

[stalkerok]

Allow to filter torrent list by infohash

👍

[xavier2k6]

@qbittorrent/bug-handlers Should we just include all column names at this stage as requested/suggested in #23774?

[stalkerok]

I don't think filtering by all columns makes sense, but can add filtering by category, tags, and addition/completion dates.

[ratijas]

Allow to filter torrent list by infohash

My five cents into bikeshedding: drop the "Allow to" and "list", it should be pretty clear from the context.

On rutracker.org it's just "by info_hash" btw:

Otherwise I don't care how is it called as long as I don't have to write ad-hoc Python scripts for basic tasks anymore (:

[xavier2k6]

drop the "Allow to" and "list"

Those words are only for the PR/commit naming.

---

This is how it will look in drop-down menu:

[ratijas]

By the way, should the drop-down be needed at all? Isn't info hash a fixed size string that is very easy to recognize with a simplest regex of all time? I was honestly surprised that I had to use the drop-down on the web-site too.

[glassez]

I don't think filtering by all columns makes sense, but can add filtering by category, tags, and addition/completion dates.

Tags and Categories are filtered using filter sidebar.

[stalkerok]

Tags and Categories are filtered using filter sidebar.

There are not many options for adding items, but filtering by categories and tags can be useful if their names partially match, as this will display several categories or tags.

[glassez]

filtering by categories and tags can be useful if their names partially match, as this will display several categories or tags.

This might make sense, but it should behave consistently with the sidebar filter as well.

[ratijas]

Tags and Categories are filtered using filter sidebar.

I was thinking about marking read/watched/unneeded torrents with a tag like "done". But then I realize there is no way to filter like not tag:done, so it won't be very useful

[xavier2k6]

I suppose any other options can be discussed in their relevant ticket(s) & any other submitted PR's.

Giving my approval for this PR anyway.

[Chocobo1]

Suggested change

	const QList<TransferListModel::Column> filterTypes = {TransferListModel::Column::TR_NAME, TransferListModel::Column::TR_SAVE_PATH, TransferListModel::Column::TR_INFOHASH_V1, TransferListModel::Column::TR_INFOHASH_V2};
	const QList<TransferListModel::Column> filterTypes = {
	TransferListModel::Column::TR_NAME
	, TransferListModel::Column::TR_SAVE_PATH
	, TransferListModel::Column::TR_INFOHASH_V1
	, TransferListModel::Column::TR_INFOHASH_V2};

[ratijas]

It's none of my business
, but out of curiosity
, which languages do you speak that put commas at the start of lines
?

[glassez]

It's not about any human language.

[glassez]

This is just to simplify the code review, as it allows you to quickly identify that this line is a continuation of the list.

[ratijas]

Don't you get at least one line of context surrounding diff either way?