Open
Conversation
glassez
changed the title
Author
|
Potentially closes #20226 as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21611.
Need to properly implement STARTTLS for secure SMTP transfer
Current implementation ties STARTTLS to enabling SMTPS which is incorrect
Implemented new option for enabling STARTTLS, to allow user control in case of compatibility issues with SMTP servers
Altered SMTP state logic to link STARTTLS to new option for enabling it
Support for SMTPS is unaffected and still the same
Background
STARTTLS is used to elevate an unencrypted SMTP session to an encrypted SMTP session after it is established, whereas SMTPS is used to establish an encrypted SMTP session from the beginning.
Different SMTP systems offer different support for each SMTP encryption option.
GUI Changes
Client Preferences
Web Preferences
Expected Behaviour
The SMTP header of the email should look similar to the following
Without STARTTLS
Received: from <qBittorrent client name> (x.x.x.x) by <outgoing SMTP server> (x.x.x.x) with SMTP Server id x.y.z via Frontend Transport; Fri, 13 Feb 2026 17:45:31 +0000With STARTTLS
Received: from <qBittorrent client name> (x.x.x.x) by <outgoing SMTP server> (x.x.x.x) with SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id x.y.z via Frontend Transport; Fri, 13 Feb 2026 08:43:18 +0000Note: exact TLS version and ciphers will vary between clients and servers