Skip to content

GHA CI: Filter out scan results from 3rd party codebases #24487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sledgehammer999 merged 1 commit into from
Jun 17, 2026
+21 −3
Merged

GHA CI: Filter out scan results from 3rd party codebases #24487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions .github/workflows/ci_ubuntu.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
# to avoid scanning 3rdparty codebases, initialize it just before building qbt
- name: Initialize CodeQL
uses: github/codeql-action/init@v4
if: startsWith(matrix.libtorrent.version, 2) && (matrix.qbt_gui == 'GUI=ON')
if: startsWith(matrix.libtorrent.version, 2.0) && (matrix.qbt_gui == 'GUI=ON')
with:
config-file: ./.github/workflows/helper/codeql/cpp.yaml
languages: cpp
Expand Down Expand Up @@ -141,9 +141,27 @@ jobs:

- name: Run CodeQL analysis
uses: github/codeql-action/analyze@v4
if: startsWith(matrix.libtorrent.version, 2) && (matrix.qbt_gui == 'GUI=ON')
if: startsWith(matrix.libtorrent.version, 2.0) && (matrix.qbt_gui == 'GUI=ON')
with:
category: ${{ github.base_ref || github.ref_name }}
category: "${{ github.base_ref || github.ref_name }} lt ${{ matrix.libtorrent.version }}"

@Chocobo1 Chocobo1 Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chocobo1 when clicking "View details" on the CI result of CodeQL, there is a warning which I don't understand at all. Any ideas?

@sledgehammer999
I figured it out. That warning is because you changed the category here from master to master lt 2.0.12 and master lt 2.1.0-rc1. The scan results is missing for the master category.
I would suggest just keep using master to simplify things as there is no such need to differentiate libtorrent versions. I'll prepare a PR to handle this.

output: sarif-results
upload: failure-only

# Filter out results from 3rdparty codebases
- name: Filter CodeQL results
uses: advanced-security/filter-sarif@2da736ff05ef065cb2894ac6892e47b5eac2c3c0 # v1.1
if: startsWith(matrix.libtorrent.version, 2.0) && (matrix.qbt_gui == 'GUI=ON')
with:
patterns: |
-src/base/3rdparty/**
input: sarif-results/cpp.sarif
output: sarif-results/cpp.sarif

- name: Upload CodeQL SARIF
uses: github/codeql-action/upload-sarif@v4
if: startsWith(matrix.libtorrent.version, 2.0) && (matrix.qbt_gui == 'GUI=ON')
with:
sarif_file: sarif-results/cpp.sarif

- name: Prepare build artifacts
run: |
Expand Down
Loading