Backport changes to v5.2.x branch#24524
Merged
Merged
Conversation
* Bump `repolevedavaj/install-nsis` action `1.2.0` -> `1.2.1` https://github.com/repolevedavaj/install-nsis/releases/tag/v1.2.1 PR qbittorrent#24495.
Replaced 3x `third party` actions with `node24 compatible` variants, addresses "Node.js 20 actions are deprecated." warnings/annotations. * [pre-commit/action](https://github.com/pre-commit/action) -> [j178/prek-action](https://github.com/j178/prek-action) * [ilammy/msvc-dev-cmd](https://github.com/ilammy/msvc-dev-cmd) -> [TheMrMilchmann/setup-msvc-dev](https://github.com/TheMrMilchmann/setup-msvc-dev) * [Wandalen/wretry.action](https://github.com/Wandalen/wretry.action) -> [nick-fields/retry](https://github.com/nick-fields/retry) PR qbittorrent#24141.
Without actually checking the old keys existence, the migration procedures might write new keys while wrongly assuming the old value is valid (it is not, it may be some default constructed value). PR qbittorrent#24502.
The rule was renamed from `no-array-for-each` to `no-for-each`. https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v66.0.0 PR qbittorrent#24521.
Per RFC 2822, only ASCII characters may appear unencoded in email headers. Latin-1 characters in the range 0x80–0xFF must be encoded (e.g. as UTF-8 base64 encoded-words). PR qbittorrent#24382.
This comment was marked as resolved.
This comment was marked as resolved.
A category with double quote breaks the CSS selector. Use CSS.escape to properly generate a correct CSS selector. PR qbittorrent#24539. Closes qbittorrent#24536.
Previously it is missing a `m_jobsMutex.unlock()` in the body of `if (!db.transaction())`. Also utilize `QMutexLocker` to handle unlock automatically. PR qbittorrent#24542.
Previously it will erroneously count empty lines and comment lines. PR qbittorrent#24544.
From http://libtorrent.org/reference-Add_Torrent.html#add_torrent_params > This is optional, if not specified trackers are assumed to be part of tier 0, or whichever the > last tier was as iterating over the trackers. PR qbittorrent#24546.
libtorrent 1.2.20 triggered `Wdeprecated-literal-operator` warning and this patch is to suppress it. PR qbittorrent#24592.
This situation will happen when there are no row in the model. PR qbittorrent#24594.
Web Seeds URL should be percent-encoded since it may contain separator characters. PR qbittorrent#24593.
Now malformed inputs such as `1.2.3.4:80:90` will not be accepted. Previously it will be parsed
into `{.ip = "1.2.3.4", .port = 80}`.
PR qbittorrent#24595.
Previously the `-` was being a range operator instead of a matching character. Also, use raw string literal. PR qbittorrent#24597.
glassez
marked this pull request as ready for review
July 3, 2026 19:11
Member
|
Member
I can take care of this but it won't be for another week as I don't have my computer with me. |
Member
Author
I've changed its milestone to 5.2.4, so it still has time to be merged. |
stalkerok
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
third partyactions #24141NSISthird party action with upstream #24495