WebUI: Handle non-torrent RSS link#24692
Open
vafada wants to merge 2 commits into
Open
Conversation
vafada
marked this pull request as ready for review
July 15, 2026 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #24685
Handle case when attempting to add a invalid torrent from a RSS link via WebUI.
A user can add a RSS url that doesn't contain valid torrent links, for example: https://fosstorrents.com/feed/rss.xml
The desktop can handle it properly by prompting an alert:
The WebUI cannot handle the error and will constantly call
fetchMetadataapi for the given url until the add torrent dialog is closed.The Add Torrent Dialog will also keep saying
Retrieving Metadata...giving the user false hope since it will NEVER resolve since the url is not a valid torrent. At the same time, the backend will continuously download the file, keep on failing and will keep logging this error on the Logs tab:qBittorrent/src/webui/api/torrentscontroller.cpp
Line 2450 in 52d3a96
This PR keeps a cache of invalid URL and would alert the user if the RSS link they are trying to download is invalid. Also pops and alert saying that url is not a valid torrent file