feat(provider): support vddns.vn#1112
Open
DNCTrung wants to merge 2 commits into
Open
Conversation
qdm12
requested changes
Apr 16, 2026
| return netip.Addr{}, fmt.Errorf("doing http request: %w", err) | ||
| } | ||
|
|
||
| if response.StatusCode != http.StatusOK { |
Owner
There was a problem hiding this comment.
if you send a request with the wrong password, what response do you get?
Author
There was a problem hiding this comment.
Service always returns StatusOK with IP
good 116.103.xx.xx
It will show an error if the base auth is not set.
badauth: 1
| response.StatusCode, utils.BodyToSingleLine(response.Body)) | ||
| } | ||
|
|
||
| err = response.Body.Close() |
Owner
There was a problem hiding this comment.
on success, what response body do you get?
Author
There was a problem hiding this comment.
Service will respond with a raw text:
good 116.103.xx.xx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the
vddnsDNS provider to the project. The main changes involve registering the new provider, implementing its logic, and integrating it into the provider selection and instantiation flow.Provider Integration:
Vddnsto the list of available providers inconstants/providers.goand included it in the provider choices. [1] [2]provider.go, enabling instantiation based on user configuration.Provider Implementation:
providers/vddns/provider.goimplementing thevddnsprovider logic, including configuration validation, update requests to the provider's API, and integration with the existing provider interface.