Skip to content

Conversation

holyMolyTolli
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Oct 6, 2025

Deploy Preview for condescending-goldwasser-91acf0 ready!

Name Link
🔨 Latest commit 8acb701
🔍 Latest deploy log https://app.netlify.com/projects/condescending-goldwasser-91acf0/deploys/68f2c828df53c300081ce83b
😎 Deploy Preview https://deploy-preview-1932--condescending-goldwasser-91acf0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@holyMolyTolli holyMolyTolli requested review from kacperlukawski and removed request for thierrypdamiba October 6, 2025 18:08
@holyMolyTolli holyMolyTolli mentioned this pull request Oct 7, 2025
Copy link
Member

@kacperlukawski kacperlukawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments regarding the lessons, and here are some important ones:

  1. Filtering does not work as described. Global filters are propagated all the way to prefetches.
  2. The Colbert reranking does not seem to be used correctly. FusionQuery does not accept a query parameter, so even if the Python client does not complain, it is not used. We probably need to nest one prefetch operation more.
  3. Recall is often used when we speak about retrieval. The latter one is more commonly used, so I tried to replace it everywhere.

In general, I would prefer to remove some parts that are mostly about filtering. We covered that already, and it's making the lessons longer than they could be.

@kacperlukawski kacperlukawski self-requested a review October 13, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants