Skip to content

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Oct 16, 2025

Copy link

netlify bot commented Oct 16, 2025

Deploy Preview for condescending-goldwasser-91acf0 ready!

Name Link
🔨 Latest commit a594dd3
🔍 Latest deploy log https://app.netlify.com/projects/condescending-goldwasser-91acf0/deploys/68f767a4df53c30009c6073d
😎 Deploy Preview https://deploy-preview-1953--condescending-goldwasser-91acf0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Anush008 Anush008 force-pushed the hybrid-search-snippets branch 3 times, most recently from ddcca7d to 63c048d Compare October 16, 2025 12:18
@Anush008 Anush008 assigned manas95826 and unassigned manas95826 Oct 16, 2025
@Anush008 Anush008 requested a review from manas95826 October 16, 2025 12:33
Signed-off-by: Anush008 <[email protected]>
@Anush008 Anush008 force-pushed the hybrid-search-snippets branch from 63c048d to 4096dae Compare October 16, 2025 12:35
```csharp
var denseModel = "sentence-transformers/all-minilm-l6-v2";
var bm25Model = "qdrant/bm25";
var dataset = LoadDataset("miriad/miriad-4.4M", "train[0:100]");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation of LoadDataset is upto the user to keep the snippets concise.

Copy link
Member

@kacperlukawski kacperlukawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm only wondering whether making a comment near to the loadDataset functions in the other languages would make sense. Something stating that it's a mock, and people can't fully reproduce it.

@kacperlukawski kacperlukawski self-requested a review October 20, 2025 08:09
Copy link
Member

@kacperlukawski kacperlukawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, was reviewing two PRs at the same time and chose the wrong option here

Signed-off-by: Anush008 <[email protected]>
@Anush008 Anush008 merged commit 5567924 into master Oct 21, 2025
5 checks passed
@Anush008 Anush008 deleted the hybrid-search-snippets branch October 21, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants