Skip to content

Conversation

@selmaVH1
Copy link
Collaborator

fixes #10473

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaict the changes introduced in the issue report affect both vector and raster display tabs

* the map tip information, i.e. the message displayed in the map canvas
when hovering over a feature of the active layer with the |mapTips| :sup:`Show Map Tips` icon pressed.
Applicable when |checkbox| :guilabel:`Enable Map Tips` is active
and no :guilabel:`HTML Map Tip` is set.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I miss an issue report (or an alternative to qgis/QGIS#63901 that was supposed to remove that option), you need to also address the removal of "HTML map tips" entry in the GUI. You might also want to check the current condition(s) for "display name" to be displayed as map tip.

when hovering over a feature of the active layer with the |mapTips| :sup:`Show Map Tips` icon pressed.
Applicable when |checkbox| :guilabel:`Enable Map Tips` is active
and no :guilabel:`HTML Map Tip` is set.
* :guilabel:`Sort Order`: an optional
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* :guilabel:`Sort Order`: an optional
* :guilabel:`Sort Order`: an optional field or

in conjunction with the :guilabel:`Display name` to provide a consistent
feature display experience.
* |checkbox| :guilabel:`Enable Map Tips` controls whether to display map tips for the layer
* The :guilabel:`HTML Map Tip` provides a complex and full HTML text editor for map tips,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be merged with previous paragraph, removing mention of "HTML map tip"

* :guilabel:`Sort Order`: an optional
:ref:`expression <vector_expressions>` that controls the default ordering
of features when displayed in the :ref:`attribute table views <attribute_table_view>` and :ref:`relation
editor widgets <vector_attributes_menu>`. You can set the sort direction
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the edit widgets section not closer to these tools than the whole Attribute forms tab url used here?

:ref:`expression <vector_expressions>` that controls the default ordering
of features when displayed in the :ref:`attribute table views <attribute_table_view>` and :ref:`relation
editor widgets <vector_attributes_menu>`. You can set the sort direction
using the arrow button next to the |expression| :guilabel:`expression` field. This setting works
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "expression" gui label here, and do we not have a substitution for the arrow icon? Using it may skip the "next to the |expression| :guilabel:expression field"?

Comment on lines +3531 to +3532
in conjunction with the :guilabel:`Display name` to provide a consistent
feature display experience.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how this is a "consistent feature display experience" is unclear to me. And I wonder if this isn't more a "dev selling a feature"-comment and something to let to changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants