Skip to content

Georeferencer updates #9759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025
Merged

Georeferencer updates #9759

merged 5 commits into from
Apr 17, 2025

Conversation

selmaVH1
Copy link
Collaborator

@selmaVH1 selmaVH1 commented Apr 3, 2025

fixes #9564
fixes #9599
fixes #7384

  • Restructured the Georeferencer chapter to support both raster and vector workflows.
  • Introduced a new section for vector georeferencing, including snapping and advanced digitizing guidance.

@@ -228,6 +230,25 @@ It is possible to choose between five different resampling methods:
#. Cubic B-Spline (4x4 kernel)
#. Lanczos (6x6 kernel)

Define the Raster creation options
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The raster creation options widget is available in many raster based algorithms (e.g. https://docs.qgis.org/testing/en/docs/user_manual/processing_algs/qgis/rasteranalysis.html#advanced-parameters) and the description of that GUI is mainly at https://docs.qgis.org/testing/en/docs/user_manual/introduction/qgis_configuration.html#gdal-createoptions. So if there are details we want to add about the default profiles, I'd suggest we mention them in the config section instead, so that it benefits to all.

When exporting a raster, |checkbox| :guilabel:`Raster creation options` allows you to define
additional options that control how the output file is structured and compressed.

Under the :guilabel:`Profile` drop-down menu, you can choose between the following options:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that the items below are simply the default options, so you can locally have more items. Or from the widget, selecting the empty entry, you can build your own combination, from scratch.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this part because there wasn’t much new information to include. I just added one Tip and referenced the section on qgis_configuration (gdal createOptions).

+--------------------------------+------------------------------+-------------------------------+-------------------------------+
| |addGCPPoint| | Add GCP Point | |deleteGCPPoint| | Delete GCP Point |
+--------------------------------+------------------------------+-------------------------------+-------------------------------+
| |moveGCPPoint| | Move GCP Point | |snapping| | Snapping Type |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing else to say on snapping?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see you just refs the issue report

@selmaVH1 selmaVH1 added NOT FOR MERGE!! georeferencer potentially new chapter labels Apr 16, 2025
@DelazJ
Copy link
Collaborator

DelazJ commented Apr 17, 2025

LGTM @selmaVH1

fixes #7384

It think it will be good to backport compatible changes to 3.40.

We should also think of the placement of the georeferencer chapter in a future PR. Raster chapter doesn't look appropriate. Candidates I can see are (no order below):

  • managing data source between "creating layers" and "exploring data formats and fields" chapters
  • visualizing-maps, no idea where exactly, either first or last chapter
  • somewhere next to the first chapters at the root of the docs
  • somewhere else... ?

@selmaVH1
Copy link
Collaborator Author

LGTM @selmaVH1

fixes #7384

It think it will be good to backport compatible changes to 3.40.

Yes, but I'm not sure how to handle that backport now, maybe I should create two pull requests one for #7384 and one for other two issues... Any advice?

We should also think of the placement of the georeferencer chapter in a future PR. Raster chapter doesn't look appropriate. Candidates I can see are (no order below):

  • managing data source between "creating layers" and "exploring data formats and fields" chapters
  • visualizing-maps, no idea where exactly, either first or last chapter
  • somewhere next to the first chapters at the root of the docs
  • somewhere else... ?

I was thinking about this, and my idea was to have a standalone chapter after the Managing Data Source or, as you suggested, to include it within the Managing Data Source after the Creating Layers.

@DelazJ
Copy link
Collaborator

DelazJ commented Apr 17, 2025

Yes, but I'm not sure how to handle that backport now, maybe I should create two pull requests one for #7384 and one for other two issues... Any advice?

Do it the old simple way, copy-paste the changes in this (these) file(s) to the file(s) in a 3.40 branch and remove what does not belong to that version (i.e. the snapping/cad and the creation options block).
We keep this PR for master and you'd create a "reduced" one for 3.40.

@DelazJ DelazJ enabled auto-merge April 17, 2025 15:37
@DelazJ DelazJ disabled auto-merge April 17, 2025 15:37
@DelazJ DelazJ merged commit 3dcf549 into qgis:master Apr 17, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
georeferencer potentially new chapter
Projects
None yet
2 participants