-
-
Notifications
You must be signed in to change notification settings - Fork 722
Georeferencer updates #9759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Georeferencer updates #9759
Conversation
@@ -228,6 +230,25 @@ It is possible to choose between five different resampling methods: | |||
#. Cubic B-Spline (4x4 kernel) | |||
#. Lanczos (6x6 kernel) | |||
|
|||
Define the Raster creation options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The raster creation options
widget is available in many raster based algorithms (e.g. https://docs.qgis.org/testing/en/docs/user_manual/processing_algs/qgis/rasteranalysis.html#advanced-parameters) and the description of that GUI is mainly at https://docs.qgis.org/testing/en/docs/user_manual/introduction/qgis_configuration.html#gdal-createoptions. So if there are details we want to add about the default profiles, I'd suggest we mention them in the config section instead, so that it benefits to all.
When exporting a raster, |checkbox| :guilabel:`Raster creation options` allows you to define | ||
additional options that control how the output file is structured and compressed. | ||
|
||
Under the :guilabel:`Profile` drop-down menu, you can choose between the following options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice that the items below are simply the default options, so you can locally have more items. Or from the widget, selecting the empty entry, you can build your own combination, from scratch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this part because there wasn’t much new information to include. I just added one Tip and referenced the section on qgis_configuration (gdal createOptions).
+--------------------------------+------------------------------+-------------------------------+-------------------------------+ | ||
| |addGCPPoint| | Add GCP Point | |deleteGCPPoint| | Delete GCP Point | | ||
+--------------------------------+------------------------------+-------------------------------+-------------------------------+ | ||
| |moveGCPPoint| | Move GCP Point | |snapping| | Snapping Type | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing else to say on snapping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I see you just refs the issue report
LGTM @selmaVH1
It think it will be good to backport compatible changes to 3.40. We should also think of the placement of the georeferencer chapter in a future PR. Raster chapter doesn't look appropriate. Candidates I can see are (no order below):
|
Yes, but I'm not sure how to handle that backport now, maybe I should create two pull requests one for #7384 and one for other two issues... Any advice?
I was thinking about this, and my idea was to have a standalone chapter after the Managing Data Source or, as you suggested, to include it within the Managing Data Source after the Creating Layers. |
Do it the old simple way, copy-paste the changes in this (these) file(s) to the file(s) in a 3.40 branch and remove what does not belong to that version (i.e. the snapping/cad and the creation options block). |
fixes #9564
fixes #9599
fixes #7384