-
-
Notifications
You must be signed in to change notification settings - Fork 722
Add geometry check and fix angle algorithms #9773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below some of my questions.
@Djedouas I'd appreciate your feedback. Thanks
- [numeric: integer] | ||
|
||
Default: 8 | ||
- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea what this is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tolerance is the order of magnitude with which the geometry computations are made.
8 means that we have an epsilon of 10^-8
So for instance, if a point is at a distance of another point of less than epsilon, they are considered on the same coordinates.
@lbartoletti could you maybe confirm and/or precise please? I think it is in map unit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 means that we have an epsilon of 10^-8
So for instance, if a point is at a distance of another point of less than epsilon, they are considered on the same coordinates.
Do you mean, possibly a distance of 0.00000001 m between two vertices 😄 ?
This is not obvious at all. Browsing a few tolerance alg parameters, the closer I could find is in "Remove duplicate vertices" alg and it is written plain decimal number. I'm pretty sure no one would have understood that and the GUI does not look correct to me: 1 would mean 10^-1 and 13 would mean 10^-13? And then the min and max would be inverted? And what if I want to use a tolerance of 1m?
Also, if it is a distance, let's then use the distance parameter type, with available units next to the widget
with accompanying screenshots
This starts documenting the Check and fix geometry algorithms, only the angle based one (refs #9530).
It has a few gaps to fill before we cover the remaining algs.
Goal:
Ticket(s): #