Skip to content

QEP 337: Coverity Scan cleanup #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

nyalldawson
Copy link
Contributor

@nyalldawson nyalldawson commented Mar 25, 2025

The Coverity Scan tool is a highly regarded tool for static analysis of complex c++ projects. It's able to pro-actively identify many code issues (such as potential crashes, memory leaks, and other unsafe behavior) which aren't picked up by other tools (such as clang-tidy or cppcheck).

Currently, the tool reports around 1075 open issues when run on the QGIS master codebase.

These issues range from false positives to trivial fixes through to serious issues which require substantial work to fix. Unfortunately, the large number of trivial issues currently reported in QGIS make the tool effectively useless for QGIS, as the critical issues are hidden amongst the many hundreds of trivial issues.

This project describes a widespread cleanup to QGIS' Coverity Scan results

View the full QEP details here: https://github.com/qgis/QGIS-Enhancement-Proposals/blob/6587f46173c0f4bc7475b151bd1a26fb030f7a29/qep-337-coverity-scan-cleanup.md

@nyalldawson nyalldawson added In Discussion QEPs currently in discussion stage Project A proposal which concerns a project, eg new functionality Grant-2025 labels Mar 25, 2025
@anitagraser
Copy link
Member

Thank you for submitting your proposal to the 2025 QGIS Grant Programme. The 2 week discussion period ends today. At the end of the discussion, the proposal author has to provide a 3-line pitch of their proposal for the voter information material. (For an example from last year check qgis/PSC#58 (comment))

@nyalldawson
Copy link
Contributor Author

@anitagraser here you go:

This project describes a widespread cleanup to QGIS' Coverity Scan static code analysis results, in order to make it easier for developers to identify high-impact issues reported by the Coverity Scan tool. There were no issues raised in the discussion.

@anitagraser anitagraser mentioned this pull request Apr 18, 2025
6 tasks
@nyalldawson nyalldawson added Voting and removed In Discussion QEPs currently in discussion stage labels Apr 28, 2025
@3nids
Copy link
Member

3nids commented Apr 28, 2025

+1

6 similar comments
@m-kuhn
Copy link
Member

m-kuhn commented Apr 28, 2025

+1

@alexbruy
Copy link
Contributor

+1

@troopa81
Copy link

+1

@nirvn
Copy link

nirvn commented Apr 28, 2025

+1

@rouault
Copy link
Contributor

rouault commented Apr 28, 2025

+1

@Samweli
Copy link

Samweli commented Apr 28, 2025

+1

@nyalldawson
Copy link
Contributor Author

Declaring as passed with approval from @rouault , @nirvn , @troopa81 , @alexbruy , @m-kuhn , @3nids

@nyalldawson nyalldawson merged commit 15bbd06 into qgis:master Apr 28, 2025
@nyalldawson nyalldawson deleted the qep_337 branch April 28, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Grant-2025 Project A proposal which concerns a project, eg new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants