Skip to content

New tools for Points Clouds from PDAL Wrench 1.3.0 #64343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JanCaha wants to merge 14 commits into
base: master
Choose a base branch
from
Open

New tools for Points Clouds from PDAL Wrench 1.3.0 #64343

JanCaha wants to merge 14 commits into from
+1,213 −0

Conversation

@JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Dec 18, 2025 •
edited
Loading

Description

Recent update to PDAL Wrench in #64303 brought several new tools. This adds QGIS Algorithms for the new tools.

New tools:

  • Classify ground points
  • Filter noise (using radius)
  • Filter noise
  • Height above ground (using triangulation)
  • Height above ground
  • Transform point cloud

@github-actions github-actions bot added this to the 4.0.0 milestone Dec 18, 2025
alexbruy
alexbruy reviewed Dec 18, 2025
View reviewed changes
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 2, 2026
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 5, 2026
@JanCaha JanCaha marked this pull request as ready for review January 5, 2026 08:15
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026 •
edited
Loading

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 2b9ad70)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This installer is not signed, control+click > open the app to avoid the warning
(Built from commit 2b9ad70)

DelazJ
DelazJ reviewed Jan 5, 2026
View reviewed changes
Copy link
Contributor

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JanCaha
Just reminding some formatting rules.

src/analysis/processing/pdal/qgsalgorithmpdalclassifyground.cpp Outdated
addParameter( new QgsProcessingParameterNumber( QStringLiteral( "SCALAR" ), QObject::tr( "Scalar" ), Qgis::ProcessingNumberParameterType::Double, 1.25 ) );
addParameter( new QgsProcessingParameterNumber( QStringLiteral( "SLOPE" ), QObject::tr( "Slope" ), Qgis::ProcessingNumberParameterType::Double, 0.15 ) );
addParameter( new QgsProcessingParameterNumber( QStringLiteral( "THRESHOLD" ), QObject::tr( "Threshold" ), Qgis::ProcessingNumberParameterType::Double, 0.5 ) );
addParameter( new QgsProcessingParameterNumber( QStringLiteral( "WINDOW_SIZE" ), QObject::tr( "Window size" ), Qgis::ProcessingNumberParameterType::Double, 18.0 ) );
Copy link
Contributor

@DelazJ DelazJ Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this label (and maybe some above) be more verbose, i.e., "Maximum filter window size"?

Copy link
Contributor Author

@JanCaha JanCaha Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mirrors parameters names in PDAL and PDAL Wrench, I would oppose changing the name.

@wonder-sk
Copy link
Member

wonder-sk commented Jan 15, 2026

@JanCaha I'd like to suggest some minor renaming:

  • Classify Ground Points -> Classify ground points
    • just fixing case to match other algorithms
  • Filter Noise (by radius algorithm) -> Filter noise (using radius)
  • Filter Noise (by statistical algorithm) -> Filter noise
    • my understanding is that the statistical method is the "default" - so let's provide it without extra label
  • Height Above Ground (by Delaunay) -> Height above ground (using triangulation)
    • to be consistent with the "export to raster" - it is also using Delaunay, and labeled as "triangulation"
  • Height Above Ground (by Nearest Neighbour) -> Height above ground
    • like with filtering of noise, let's have NN as the "default" approach
  • Transform coordinates of point cloud -> Transform point cloud
    • just to make it a bit shorter

wonder-sk
wonder-sk approved these changes Jan 15, 2026
View reviewed changes
Copy link
Member

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor documentation bit + renaming of algs as commented above...

@qgis qgis deleted a comment from github-actions bot Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexbruy alexbruy alexbruy left review comments

@wonder-sk wonder-sk wonder-sk approved these changes

+1 more reviewer

@DelazJ DelazJ DelazJ left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JanCaha @wonder-sk @alexbruy @DelazJ