Remove obsolete class QRegExp #64522
Open
+31
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
rouault
reviewed
Jan 14, 2026
Contributor
|
Can you also |
The message was emitted by GDAL < 3
02JanDal
force-pushed
the
refactor/remove-obsolete-qregexp
branch
from
c8b02e0 to
48b3c4d
Compare
Contributor
Author
|
@uclaros Done, though could you explain why? I could understand it if they where global static variables and thus could be accessed by multiple threads, but these are local? |
Collaborator
|
@02JanDal it's a performance boost -- constructing regex is not cheap, so this ensures they are only constructed a single time |
Contributor
Author
|
Ah, I see (haven't really used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QRegExpwas superseeded byQRegularExpressionin Qt 5, and moved to the Qt 5 Compatibility module in Qt 6.This PR replaces the last usages of
QRegExpbyQRegularExpression. There are some differences in pattern handling between the two, however nothing which affected the patterns in question AFAICT.