Extend interactive workflow instructions for multinetwork systems#1200
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
=======================================
Coverage 97.91% 97.91%
=======================================
Files 131 131
Lines 10034 10034
=======================================
Hits 9825 9825
Misses 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
andrea-pasquale
left a comment
There was a problem hiding this comment.
Thanks for the update @alecandido.
I tried to test the code, but I'm getting the following error:
hostname: illegal option -- I
usage: hostname [-f] [-s | -d] [name-of-host]
Traceback (most recent call last):
File "<string>", line 4, in <module>
IndexError: list index out of rangeWhich is due to the fact that on MacOS the hostname command doesn't have the option -I. Should we try to generalize the script to support also MacOS? Otherwise we should put in the documentation that the script is working only for Linux.
True, the script is only intended to work on Linux. So, it is not written for MacOS, nor for Windows. But which MacOS or Windows cluster do you have in mind? |
My bad. I thought that the command was supposed to be launched from my local machine. |
On that note, we could actually add some notes in the docs on where each part is meant to be executed as the script is not easy to understand without experience in bash, so it may not be clear to everyone (it wasn't to myself initially too). In particular:
|
Preventing some unneeded warnings
9003bbd to
4e0fc2e
Compare
|
This should be now rebased on current |
andrea-pasquale
left a comment
There was a problem hiding this comment.
Thanks @alecandido
The workflow proposed in #1184 was flawed for systems part of multiple networks, since a single one was assumed.
This is actually the case of TII's quantum computing lab, for which
SUBNETshould be set to"192.168.2".sbatched)