Skip to content

Extend interactive workflow instructions for multinetwork systems#1200

Merged
andrea-pasquale merged 6 commits into
mainfrom
expose-web-multinet
Jul 31, 2025
Merged

Extend interactive workflow instructions for multinetwork systems#1200
andrea-pasquale merged 6 commits into
mainfrom
expose-web-multinet

Conversation

@alecandido

@alecandido alecandido commented Jul 7, 2025

Copy link
Copy Markdown
Member

The workflow proposed in #1184 was flawed for systems part of multiple networks, since a single one was assumed.

This is actually the case of TII's quantum computing lab, for which SUBNET should be set to "192.168.2".

  • explain the script it is intended to be submitted to the queue (sbatched)
  • link to the token page in Jupyter docs, since the token request is possibly unexpected

@codecov

codecov Bot commented Jul 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.91%. Comparing base (14a53ce) to head (12dd989).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files         131      131           
  Lines       10034    10034           
=======================================
  Hits         9825     9825           
  Misses        209      209           
Flag Coverage Δ
unittests 97.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread doc/source/tutorials/connect-to-queue.bash

@andrea-pasquale andrea-pasquale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @alecandido.

I tried to test the code, but I'm getting the following error:

hostname: illegal option -- I
usage: hostname [-f] [-s | -d] [name-of-host]
Traceback (most recent call last):
  File "<string>", line 4, in <module>
IndexError: list index out of range

Which is due to the fact that on MacOS the hostname command doesn't have the option -I. Should we try to generalize the script to support also MacOS? Otherwise we should put in the documentation that the script is working only for Linux.

@alecandido

Copy link
Copy Markdown
Member Author

Which is due to the fact that on MacOS the hostname command doesn't have the option -I. Should we try to generalize the script to support also MacOS? Otherwise we should put in the documentation that the script is working only for Linux.

True, the script is only intended to work on Linux. So, it is not written for MacOS, nor for Windows.

But which MacOS or Windows cluster do you have in mind?

@andrea-pasquale

Copy link
Copy Markdown
Contributor

But which MacOS or Windows cluster do you have in mind?

My bad. I thought that the command was supposed to be launched from my local machine.

@stavros11

Copy link
Copy Markdown
Member

My bad. I thought that the command was supposed to be launched from my local machine.

On that note, we could actually add some notes in the docs on where each part is meant to be executed as the script is not easy to understand without experience in bash, so it may not be clear to everyone (it wasn't to myself initially too). In particular:

  1. connect-to-queue.bash should be executed in the partition you plan to run the notebook on. For example using srun -p <partition-name> ./connect-to-queue.bash worked for me.
  2. This will print a message to forward a port using ssh <login-node> -L 9180:$IP:$PORT". This should run on your local machine (also tested on Windows cmd).
  3. Opening jupyter in the browser usually works better for me using the link that jupyter gives http://127.0.0.1:<port>/lab?token=<some-token> rather than the one printed by our script (I just need to replace <port> with 9180 which is the one we are forwarding to). Using the localhost link sometimes doesn't work and if it does I still need to copy paste the token to authenticate.

@alecandido alecandido force-pushed the expose-web-multinet branch from 9003bbd to 4e0fc2e Compare July 29, 2025 17:40
@alecandido

Copy link
Copy Markdown
Member Author

This should be now rebased on current main, and contains all the suggested annotations.

@andrea-pasquale andrea-pasquale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alecandido

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit fe08c22 Jul 31, 2025
39 checks passed
@andrea-pasquale andrea-pasquale deleted the expose-web-multinet branch July 31, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants