Fix update in resonator spectroscopy at low power#1217
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
=======================================
Coverage 97.91% 97.91%
=======================================
Files 131 131
Lines 10033 10034 +1
=======================================
+ Hits 9824 9825 +1
Misses 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Luca-Ben-Herrmann
approved these changes
Jul 29, 2025
Luca-Ben-Herrmann
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this, I am confirming that the fix works: http://login.qrccluster.com:9000/dxm2DLDxROSJ1O2qfINVIw==
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running at low power we were not updating the
dressed_resonator_frequencywhich is what we are scanning around.