MAINT: vendor vega assets - #94
Conversation
lizgehret
left a comment
There was a problem hiding this comment.
Hey @johnchase thanks for this contribution, this had been on my list for quite some time!
Initial review looks good with a few small formatting requests. I'm going to do some local testing/poking around; I'll follow up in the next couple of days if anything else is needed before getting this merged!
|
Hey @johnchase I'm going to go ahead and implement these suggestions to save you some time (assuming you won't mind) |
|
Another follow-up; I did a bit more refactoring to the viz rendering that will make it easier to refactor the asset tests so we aren't hard coding the visualizations that currently exist (and rather are doing these checks against all available visualizations at any point in time). I'm going to finish this up tomorrow and then will have @misialq review! |
|
Okay refactor is all finished and ready for your review @misialq 🙂 |
misialq
left a comment
There was a problem hiding this comment.
LGTM @lizgehret! 🎉 (I tested using the boxplot visualization)
|
Note for posterity (moving from the vendor README): As of these PR changes, the size of each .qzv generated will now increase in size by 194.6 KB (when compressed). |
Description
AI Disclosure
AI Usage Details
Tool: Codex, using GPT-5.
Codex inspected the issue and contribution guidance.
Codex produced all new Python implementation, tests, and vendor documentation.
Codex downloaded the pinned upstream Vega assets, verified checksums, ran tests/linting, and pushed the commits.
User independently tested plugin, verified visualization, tested offline usage.
User defined implementation details such as package structure and naming
User independently reviewed PR