Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using the md5 code that gets updated when SBCL internals warrant. #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Start using the md5 code that gets updated when SBCL internals warrant. #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion sbcl.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,19 @@
(eval-when (:compile-toplevel :load-toplevel :execute)
;; MD5 pulls in SB-ROTATE-BYTE which makes it impossible
;; to compile either of those from fresh upstream sources without some magic.
(require :sb-md5))
(require :sb-md5)
;; Avoid ever recompiling the github MD5 because it unportably uses SBCL internals,
;; and in attempting to address the PR (https://github.com/pmai/md5/issues/3)
;; the author caused some new style-warnings to be generated.
;; We don't need to keep chasing problems; just use the contrib module as if it were
;; named MD5. You might think that this rename step should be done when building
;; the SBCL contrib module, but that would completely remove the ability to build and
;; test the upstream MD5, at least until it becomes a thin shim.
;; Whereas anything built with the bazel build rule needs MD5 because of this
;; file per se needing it; and weird problems crop up when attempting to define
;; //third_party/lisp/md5 in such a way that a package rename occurs when and
;; only when that lisp_library() is loaded. So do it now, which always works.
(rename-package "SB-MD5" "SB-MD5" '("MD5")))

(defpackage #:bazel.sbcl
(:use #:common-lisp #:sb-thread #:sb-alien #:bazel.utils)
Expand Down