fix: add filters info in footnote #1710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
wrong footer size when theme is a card theme and |
Caele
reviewed
Apr 4, 2025
Contributor
Author
I added padding and border top style for filter footnote with card theme. Removed padding top when new sheet flag is enabled (previously 8px). Padding top for non card theme, like sense classic is 6px, for card theme is 0px. I am not sure if it is always the case, or can change padding top in themes. I noticed font size and style is not applied for some themes, both for normal footnote text or filter information. I am not sure if it is related to your changes of applying theme. I will check, but will not make change in this PR. |
jjxie
commented
Apr 28, 2025
T-Wizard
reviewed
Apr 29, 2025
T-Wizard
reviewed
Apr 29, 2025
T-Wizard
reviewed
Apr 29, 2025
T-Wizard
approved these changes
Apr 30, 2025
Caele
reviewed
May 5, 2025
Caele
approved these changes
May 5, 2025
Caele
pushed a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Added support of showing filters information in footnote.
generateSetExpression.jsis same check for classic chartNone card theme
Card theme
Requirements checklist
yarn specWhen build and tests have passed: