-
Notifications
You must be signed in to change notification settings - Fork 57
feat: add viewDataToggled and toggleFocus #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Christian Veinfors <[email protected]>
T-Wizard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
I am a bit unsure about setOnBlurHandler
I would like something that is easier to understand and use, but don't have any suggestion on what that would be
I agree, its messy. The whole thing depends on how we handle keyboard nav, either internally in Nebula or externally. And as we don't run a single Nebula instance in embed we need to keep it external (also as we need the sheet to control the ordering of the charts when tabbing/navigating). There might be a combined way we can simplify things, Lihn is fighting it. |
Caele
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linhnguyen-qlik think you can merge when you are satisfied, we'll need to continue tinker with parts of this anyways.
Co-authored-by: Christian Veinfors <[email protected]>
|
@Caele The strange thing is that boxplot doesn't have definition.ext but in production it could still toggleViewData. Just comment here so we don't forget to check this out. I am going to merge this for now. |
Motivation
Requirements checklist
yarn specWhen build and tests have passed: