chore: add emitter to sheet Cell #1712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Wizard
reviewed
Apr 7, 2025
| style.padding = '4px'; | ||
| } | ||
|
|
||
| const emitter = new EventEmitter(); |
Collaborator
There was a problem hiding this comment.
I think this maybe will create a new emitter for all cells when any cell is added or removed from the sheet
Collaborator
Author
There was a problem hiding this comment.
Yea probably, I'll take another look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Emitter needs to be defined even on sheets to exits for charts that use it, even if it isn't exposed through the Sheet api.
Requirements checklist
yarn specWhen build and tests have passed: