-
Notifications
You must be signed in to change notification settings - Fork 57
chore: add hypercube generic functions to nebuls.js, part01 #1716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- apis/nucleus/package.json: Language not supported
- package.json: Language not supported
d12ed36 to
d701919
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (3)
- apis/nucleus/package.json: Language not supported
- apis/stardust/api-spec/spec.json: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (2)
apis/nucleus/src/utils/handlers/hypercube-handlers.js:23
- [nitpick] The inline ternary inside the template literal is redundant. Consider simplifying the expression to use
${this.path}.qHyperCubeDefwhen this.path exists for improved clarity.
? utils.getValue(properties, `${this.path ? `${this.path}.` : ''}qHyperCubeDef`)
apis/conversion/src/array-util.js:77
- [nitpick] Using Array.isArray(array) is generally preferred over instanceof Array for broad reliability across different execution contexts.
if (!(array instanceof Array)) {
eaa2870 to
0b1317b
Compare
d6a9130 to
1379f85
Compare
222061c to
96e0ca5
Compare
c62f495 to
7ee1ab0
Compare
7ee1ab0 to
430b60c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
fe9e437 to
63b983e
Compare
|
@Caele I added the flag so it works only when the flag is enabled. Do you think the PR is ready to merge? Btw, I disabled checking Eslint for some imports from the other packages for now, since you mentioned we prefer to not to add other packages dependencies. But we should probably come up with a better solution for that, maybe moving those util functions to the parent package so they can be easily called in different packages without necessity to add a specific dependency? |
63b983e to
c56321c
Compare
Caele
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can go ahead with this now. Not sure about the extra line in the spec file. but thats probably an auto fix thing.
Motivation
Moving generic hypercube functions from sense-client to nebula.js - Part01.
At this PR only the functions that are required to display the fields in property-panel are considered. The rest of the functions will be moved to this repo in the coming PRs.
The source files for these functions are in sense-client (data-property-handler.ts & hypercube-handler.js)
Required Flag: NEBULA_DATA_HANDLERS
Requirements checklist
yarn specWhen build and tests have passed: