Skip to content

Add Katana60 rev3 (pro) and Tsuka60 rev1 (pro) #22904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Add Katana60 rev3 (pro) and Tsuka60 rev1 (pro) #22904

wants to merge 11 commits into from

Conversation

rominronin
Copy link
Contributor

Description

Add 2 new keyboards: Katana60 Pro and Tsuka60 Pro. Both boards have USB-C ports and ESD protection.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

@rominronin
Copy link
Contributor Author

Hi, the last time I contributed, the next major release was in the near future. Since then it's been released and creating a custom firmware has changed quite a bit!

I've updated my fork and it seems this is a mergeable branch, however I would like some help with getting via working. Any pointers would be greatly appreciated, thanks.

fauxpark
fauxpark requested changes Jan 15, 2024
View reviewed changes
@fauxpark fauxpark requested a review from a team January 15, 2024 12:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Mar 1, 2024
@rominronin
Copy link
Contributor Author

I am making time for these fixes this weekend, please do not delete/archive the PR

@rominronin
Copy link
Contributor Author

I think I have addressed all requests now. Thanks @fauxpark

@rominronin rominronin requested a review from fauxpark March 11, 2024 18:28
@drashna drashna requested a review from a team March 12, 2024 16:37
@drashna drashna requested a review from a team March 30, 2024 01:58
@rominronin
Copy link
Contributor Author

Hello, thanks for all the contribution so far.
What is the status of this pull request now? Do I need to do anything further? Thanks

fauxpark
fauxpark requested changes Apr 27, 2024
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard updates need to go through develop.

@rominronin
Copy link
Contributor Author

Keyboard updates need to go through develop.

So I just have to update my target branch?

@rominronin rominronin changed the base branch from master to develop April 27, 2024 03:00
@rominronin
Copy link
Contributor Author

Updated the base branch to develop 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cipulot Cipulot Cipulot left review comments

@fauxpark fauxpark fauxpark requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
in progress keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rominronin @drashna @fauxpark @Cipulot