[CLI] Refactor open
into pathlib.Path.open
#23105
Draft
+21
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per title.
While doing a PR i noticed a few
open(Path, mode)
lines which felt a bit off (non-idiomatic), and after looking foropen
onlib/python
i've noticed that code does indeed use this method on most places, so refactored the ones that don't for consistency.Notes:
Path
orstr
looking at the code and added a couple type hints on my way to discoverystrip
be used instead onrstrip
? ie: remove leading -and not trailing- spaces that would make thestr.startswith
not detect an existing commentTypes of Changes
Issues Fixed or Closed by This PR
Checklist