Skip to content

Add keycode aliases for Japanese JIS kana input (#24921) #24923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

stringthread
Copy link

@stringthread stringthread commented Feb 16, 2025

Description

Defined the keycode aliases based on the Japanese JIS kana input (かな入力), whose keymap is shown below:

Kana keymap without Shift
Kana keymap without Shift

Kana keymap with Shift
Kana keymap with Shift

Here are the examples of the keycode aliases. They starts with JK_.

Letter Alias Keycode
あ (a) JK_A KC_3
か (ka) JK_KA KC_T
゛(voiced consonant mark) JK_VOICE KC_LBRC

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

I'm not sure if documentation changes of tests are required.

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core dd Data Driven Changes labels Feb 16, 2025
@drashna drashna requested review from fauxpark and a team February 28, 2025 19:27
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core dd Data Driven Changes stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant