-
-
Notifications
You must be signed in to change notification settings - Fork 41.2k
New manuform layout #25098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New manuform layout #25098
Conversation
I'm not able to solve this error... can someone help me? |
"matrix_pins": {
"cols": ["D4", "C6", "D7", "E6", "B4", "B5"], You have 6 columns defined, but are referencing a 7th one within the layout macro. Given this isn't anywhere close to compiling, it cannot have been tested locally. If you intend to go forward with this PR, please,
If you require help with the above, then hop over to the Discord. A PR is not the place for this discussion as the problems should have be resolved before it were even created. |
HI, how this change can be merged in the qmk:master branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should match the default template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated following this template https://github.com/qmk/qmk_firmware/blob/master/data/templates/keyboard/readme.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, still doesnt match the template. Note the markdown/indentation/etc used in https://raw.githubusercontent.com/qmk/qmk_firmware/refs/heads/master/data/templates/keyboard/readme.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readme updated base on the template above
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
…rmware into new-manuform-layout
Added a new manuform layout 4x7_6_3.
Description
Added new layout in folder keyboard->handwired->dactyl_manuform
Types of Changes
Issues Fixed or Closed by This PR
Checklist