Skip to content

New manuform layout #25098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

New manuform layout #25098

wants to merge 15 commits into from

Conversation

AGia5
Copy link

@AGia5 AGia5 commented Apr 6, 2025

Added a new manuform layout 4x7_6_3.

Description

Added new layout in folder keyboard->handwired->dactyl_manuform

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@AGia5
Copy link
Author

AGia5 commented Apr 6, 2025

I'm not able to solve this error...
In file included from .build/obj_handwired_dactyl_manuform_4x7_6_3_default/src/default_keyboard.c:26:
./.build/obj_handwired_dactyl_manuform_4x7_6_3_default/src/default_keyboard.h:29:2: error: #error (".h is required unless your keyboard uses data-driven configuration. Please rename your keyboard's header file to .h")
#error(".h is required unless your keyboard uses data-driven configuration. Please rename your keyboard's header file to .h")

can someone help me?

@zvecr
Copy link
Member

zvecr commented Apr 6, 2025

linting handwired/dactyl_manuform/4x7_6_3
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 6 (k0G) is 6 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 13 (k4G) is 6 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 20 (k1G) is 6 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 27 (k5G) is 6 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 43 (k7L) is 11 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 44 (k7M) is 12 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 45 (k7N) is 13 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 6 (k0G) is 6 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 13 (k4G) is 6 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 20 (k1G) is 6 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 27 (k5G) is 6 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 43 (k7L) is 11 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 44 (k7M) is 12 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: LAYOUT: Matrix column for key 45 (k7N) is 13 but must be less than 6
☒ handwired/dactyl_manuform/4x7_6_3: Errors found when generating info.json.
☒ Lint check failed for: handwired/dactyl_manuform/4x7_6_3

    "matrix_pins": {
        "cols": ["D4", "C6", "D7", "E6", "B4", "B5"],

You have 6 columns defined, but are referencing a 7th one within the layout macro.

Given this isn't anywhere close to compiling, it cannot have been tested locally. If you intend to go forward with this PR, please,

  1. Refrain from opening/closing any more PRs
    • Push any further changes to the same branch and they will be reflected here.
  2. Test your submission
    • On actual hardware and ensure its in a working state
  3. Resolve flagged issues
    • This includes any of the errors produced from compile and from qmk lint
    • And those covered in the PR checklist
    • Add readme.md following the template

If you require help with the above, then hop over to the Discord. A PR is not the place for this discussion as the problems should have be resolved before it were even created.

@AGia5
Copy link
Author

AGia5 commented Apr 12, 2025

HI, how this change can be merged in the qmk:master branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should match the default template.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, still doesnt match the template. Note the markdown/indentation/etc used in https://raw.githubusercontent.com/qmk/qmk_firmware/refs/heads/master/data/templates/keyboard/readme.md.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme updated base on the template above

@AGia5 AGia5 requested a review from drashna April 15, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants