Skip to content

Correct GHS JEM directory #25118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Correct GHS JEM directory #25118

wants to merge 3 commits into from

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Apr 8, 2025

Amend titled directory to match it's physical counterpart

cc: @ramonimbao

Description

reference

  • moved layouts LAYOUT_all and LAYOUT_iso to, sub-directory, /soldered
    • /hotwap_ansi doesn't support named layouts
  • default keymap moved to /keymaps
    • default keymap for /soldered and /hotswap_ansi were identical
  • layout names changed to match Community layouts
    • layout aliases added
  • LAYOUT_all layout alias added to /hotswap_ansi to meet PR Checklist requirements regarding multi-layout boards

note: had to define community layouts per sub-dir (/soldered and /hotswap_ansi), as having community layout(s) in top-dir (/keyboards/ghs/jem) for some reason prevents community layout(s) in sub-dir from being included in CI builds.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant