Skip to content

Avoid duplication in generated community modules rules.mk #25135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 11, 2025

Description

Due to the way the content was previously generated, the moving of module config to slightly later does not change the effective order.

Also avoids the scenario where keymap.json "keyboard` field has a different value to the currently comping keyboard. This can happen when a keymap is shared across multiple revisions (or just set to a completely incorrect value).

keyboards/test/rev1/keyboard.json - include module A
keyboards/test/rev2/keyboard.json - include module B
keyboards/test/keymaps/default/keymap.json - include module C sets keyboard field to "test/rev1"

If you then compile test/rev2:default it will incorrectly pull in modules A, B and C

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core python cli qmk cli command labels Apr 11, 2025
@zvecr zvecr changed the title Avoid duplication in rules.mk for community modules Avoid duplication in generated community modules rules.mk Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command core python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant